Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Make the Gallery linkable even after scrolling past several pages #1435

Closed
jmathai opened this Issue · 3 comments

2 participants

Jaisen Mathai Jj
Jaisen Mathai
Owner

Related to #1434

At the moment when you scroll past a few pages the URL doesn't get updated. So if the URL is copied and pasted it sort of loses context.

I say, sort of, because in essence the page is dynamic and the visitor can scroll down to the section you were looking at. But the intent is probably more along the lines of what photos are in the viewport of the browser. I'm not sure if we can target that closely but there's got to be some happy middle ground on retaining the intent of the user when copying/pasting a link somewhere.

Jj

Is it possible to have normal pagination? That way you can link to ?page=4 or click to ?page=5000 because the current infinite scroll makes it effectively impossible to query old photos.

A drawback of normal pagination is that the photos on ?page=X are not the same once more photos get uploaded, but there could be date archive navigation so you can go to /2013/12/24/?page=x and then those are less likely to vary over time.

Jaisen Mathai
Owner
Jaisen Mathai
Owner

We launched pagination with our infinite scroll on trovebox.com.

Here's a write up about it https://medium.com/p/636c0ae6e3b1 and a working example https://current.trovebox.com/photos/page-10/list

Jaisen Mathai jmathai referenced this issue from a commit
Jaisen Mathai jmathai Adding "previous page" if linking to interior pages (> 1). #1435
Conflicts:
	src/html/assets/themes/fabrizio1.0/config/settings.ini
14b0d04
Jaisen Mathai jmathai closed this issue from a commit
Jaisen Mathai jmathai Adding pushstate updating of URL for infinite scrolling. Closes #1435
Conflicts:
	src/html/assets/themes/fabrizio1.0/javascripts/gallery.js
	src/html/assets/themes/fabrizio1.0/javascripts/op/Lightbox.js
	src/html/assets/themes/fabrizio1.0/javascripts/op/Util.js
	src/html/assets/themes/fabrizio1.0/templates/template.php
754941f
Jaisen Mathai jmathai closed this in 754941f
Jaisen Mathai jmathai referenced this issue from a commit
Jaisen Mathai jmathai Adding "previous page" if linking to interior pages (> 1). #1435
Conflicts:
	src/html/assets/themes/fabrizio1.0/config/settings.ini
	src/html/assets/themes/fabrizio1.0/stylesheets/less/components/photo-grid.less
	src/html/assets/themes/fabrizio1.0/templates/partials/photos-sub-heading.php
	src/libraries/controllers/PhotoController.php
45d42b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.