Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SampleFilter.js uniform resolution should be type vec2, not vec3 #1137

Closed
VictoryRice opened this issue Aug 24, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@VictoryRice
Copy link

commented Aug 24, 2014

The SampleFilter.js included in the filters directory says in the comments,

By default the following uniforms are already created and available:
...
uniform vec3 resolution - The dimensions of the filter. Can be set via setSize(width, height)

Actually I've found it must be declared as uniform vec2 or else errors ensue. You can see in the Fire.js filter example that it's a vec2.

@photonstorm

This comment has been minimized.

Copy link
Owner

commented Aug 28, 2014

Very true - fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.