Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved consistency of clone methods on geometry classes #1130

Merged
merged 7 commits into from Aug 28, 2014

Conversation

@beeglebug
Copy link
Contributor

commented Aug 21, 2014

I noticed there was some inconsistency between the various Geom classes clone methods.

I added a clone function to both the Line and Polygon classes, then I made sure all the function signatures and argument checks were the same.

I also tidied up the Polygon class slightly by using the setter logic in the constructor instead of duplicating code.

@beeglebug beeglebug changed the title Feature/clone consistency Improved consistency of clone methods on geometry classes Aug 21, 2014

photonstorm added a commit that referenced this pull request Aug 28, 2014
Merge pull request #1130 from beeglebug/feature/clone-consistency
Improved consistency of clone methods on geometry classes

@photonstorm photonstorm merged commit e8ca3a8 into photonstorm:dev Aug 28, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@photonstorm

This comment has been minimized.

Copy link
Owner

commented Aug 28, 2014

Nice! Merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.