Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace images hosted on Twitter #28

Closed
alexislefebvre opened this issue Nov 20, 2020 · 6 comments
Closed

Replace images hosted on Twitter #28

alexislefebvre opened this issue Nov 20, 2020 · 6 comments
Labels
done Implemented, merged and tested

Comments

@alexislefebvre
Copy link
Contributor

alexislefebvre commented Nov 20, 2020

Some images are provided by Twitter: https://github.com/photoprism/photoprism-docs/search?q=twimg

These images are blocked by Firefox when using the Strict Enhanced Tracking Protection from Firefox.

So instead of images, we see white rectangle or nothing.

These images should be hosted elsewhere. Ideally on the same server than the doc to avoid depending on an external resource.

Example on https://docs.photoprism.org/developer-guide/metadata/classification/ :

image

@graciousgrey graciousgrey added the todo Ready for implementation label Nov 22, 2020
@lastzero
Copy link
Member

True. Only affects the developer guide though?

@alexislefebvre
Copy link
Contributor Author

This page is affected too: https://docs.photoprism.org/user-guide/settings/library/

graciousgrey added a commit that referenced this issue Nov 23, 2020
@graciousgrey
Copy link
Member

Should be fixed now, let me know in case I forgot one.

@graciousgrey graciousgrey added done Implemented, merged and tested and removed todo Ready for implementation labels Nov 23, 2020
@alexislefebvre
Copy link
Contributor Author

alexislefebvre commented Nov 24, 2020

It looks like it's not deployed as for now.

@graciousgrey
Copy link
Member

True, I forgot to deploy - now it is ;)

@alexislefebvre
Copy link
Contributor Author

Nice, I can see images now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Implemented, merged and tested
Projects
None yet
Development

No branches or pull requests

3 participants