Repository navigation
Vision Service: Add Ollama and Data URL support - #5
Conversation
- reduced copy and paste JSON structures - extracted model management to a separate class
- Now each implementation of ImageProcessor tests whether it can process a request. The first eligible implementation is used.
- it would be better create configuration file with separate prompts for each model and use case
- if there is label, it must have name and confidence - we want only short descriptive labels
|
@sgflt Thank you very much! 🥳 See comment in the related issue for feedback: |
- local tensorflow model (better performance) - ollama best effort (may hallucinate)
|
@sgflt Awesome, that looks like a huge improvement! 🥇 How about adding some documentation about the new features and changes? 🤔
To reduce the effort, it would be sufficient to add this information to the existing README.md. It also seems like a good idea to include the (most important) variables in the compose.yaml configuration example, so that users see them even if they don't read the docs. Note that the Don't worry too much about typos, as we can edit the docs later to improve readability. If you have any questions, please feel free to write an email or get in touch via Element/Matrix! 💬 |
|
|
@sgflt I don't see these changes. Maybe you haven't pushed them yet? |
|
Thank you very much! I'll go ahead and merge this if there's nothing you want to add? |
|
Okay. I have some minor cleanups as had found that python since 3.9 have better typing hints, but I will do other pull request under different issue. |
Refactored code in a way that will support easy addition of another caption providers.
Related Issues: