Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebDAV: Keep favorite flag when uploading via PhotoSync #1210

Closed
graciousgrey opened this issue Apr 20, 2021 · 2 comments
Closed

WebDAV: Keep favorite flag when uploading via PhotoSync #1210

graciousgrey opened this issue Apr 20, 2021 · 2 comments
Assignees
@lastzero
Labels
enhancement Optimization, improvement or maintenance task released Available in the stable release

Comments

@graciousgrey
Copy link
Member

graciousgrey commented Apr 20, 2021 •
edited

As a user, that uses PhotoSync in combination with PhotoPrism, I want photos that have been marked as favorite on my phone to be marked in PhotoPrism as well, so that I do not need to mark photos as favorite twice.

Acceptance Criteria:

  • Mark a photo as favorite when it comes with the header
  • Read Recordtime header in case the photo/video has no exif data
  • Add unit tests
  • Update documentation
@graciousgrey graciousgrey added the enhancement Optimization, improvement or maintenance task label Apr 20, 2021
@dror3go
Copy link

dror3go commented Apr 20, 2021

@graciousgrey is there a different way to get this favorite boolean other than a X- header prefix? This "custom header" prefix has been deprecated back in 2012.

@graciousgrey graciousgrey changed the title Interpret X-Headers from PhotoSync Interpret favorite information from PhotoSync Apr 20, 2021
@lastzero lastzero changed the title Interpret favorite information from PhotoSync WebDAV: Mark uploaded files as favorite if X-Favorite header is set Apr 30, 2021
lastzero added a commit that referenced this issue Apr 30, 2021
@lastzero
WebDAV: Mark uploaded files as favorite #1210
8851271
@lastzero lastzero added the please-test Ready for acceptance test label Apr 30, 2021
@lastzero lastzero changed the title WebDAV: Mark uploaded files as favorite if X-Favorite header is set WebDAV: Keep favorite flag when uploading via PhotoSync May 1, 2021
@lastzero
Copy link
Member

lastzero commented May 5, 2021

This has been released. Note that PhotoSync for Android might not send the required header yet, so it may only work on iOS so far.

@lastzero lastzero closed this as completed May 5, 2021
@lastzero lastzero added released Available in the stable release and removed please-test Ready for acceptance test labels May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lastzero lastzero

Labels
enhancement Optimization, improvement or maintenance task released Available in the stable release
Projects
Roadmap 🚀✨
Status: Released 🌈
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lastzero @dror3go @graciousgrey and others