TIFF: Support all features

[iwinstar]

version: 211007-8f55d6f8-Linux-x86_64 (latest)

detail logs:

INFO[2021-10-09T07:51:37Z] tiff: converting photo-1415886541506-6efc5e4b1786.tiff to jpg
ERRO[2021-10-09T07:51:38Z] resample: can't open photo-1415886541506-6efc5e4b1786.tiff
WARN[2021-10-09T07:51:38Z] index: failed converting photo-1415886541506-6efc5e4b1786.tiff to jpeg (tiff: invalid format: not enough pixel data)
INFO[2021-10-09T07:52:33Z] tiff: converting photo-1584886781099-0664a292d9b0.tiff to jpg
ERRO[2021-10-09T07:52:33Z] resample: can't open photo-1584886781099-0664a292d9b0.tiff
WARN[2021-10-09T07:52:33Z] index: failed converting photo-1584886781099-0664a292d9b0.tiff to jpeg (tiff: unsupported feature: color model)

"tiff: unsupported feature: color model" seems easy to fix:
photoview/photoview#242

"tiff: invalid format: not enough pixel data" no idea how to fix it.

I also provide those two photos for you guys to test. Thanks.

[iwinstar]

each photo is 40MB+, seems too large to directly upload under this issue, any other way?

Photos.zip
Photos.z01.zip
Photos.z02.zip
Photos.z03.zip

After download those files,

rename Photos.z01.zip to Photos.z01
rename Photos.z02.zip to Photos.z02
rename Photos.z03.zip to Photos.z03

Then decompress Photos.zip

[lastzero]

I trust that some TIFF files can't be decoded... that's the full TIFF spec: https://www.adobe.io/content/dam/udp/en/open/standards/tiff/TIFF6.pdf

The Go authors didn't implement all of it. We don't have the financial resources either if Google doesn't.

[maxammann]

We actually could use Darktable for conversion from TIFF to JPEG.

[iwinstar]

root@nas:/photoprism# darktable-cli originals/photo-1415886541506-6efc5e4b1786.tiff a.jpg
[rawspeed] (photo-1415886541506-6efc5e4b1786.tiff) rawspeed::RawImage rawspeed::RawDecoder::decodeRaw(), line 273: const rawspeed::TiffIFD* rawspeed::TiffIFD::getIFDWithTag(rawspeed::TiffTag, uint32_t) const, line 219: failed to find 1 ifs with tag 0x828e
[export_job] exported to `a.jpg'

root@nas:/photoprism# darktable-cli originals/photo-1584886781099-0664a292d9b0.tiff b.jpg
[export_job] exported to `b.jpg'

photo-1415886541506-6efc5e4b1786.tiff 45MB(tiff) -> 12MB(jpg)
photo-1584886781099-0664a292d9b0.tiff 42MB(tiff) -> 4.3MB(jpg)

It seems fine for me.

[maxammann]

raw0037.tif.xmp.zip

Nice, here is another example which works and has a corresponding xmp file.

[CDeLeon94]

What's the solution for now, manually convert via darktable-cli?
Does that just leave the originals un-index and un-imported, with only the conversions being present within photoprism?

[lastzero]

The solution would be to have time to build one, which we don't have at the moment. This issue has not received much attention from users, so it has not been a top priority for us, given the number of other requests. A few lines of code should resolve it if you use an external converter instead of the built-in TIFF library (don't ask me why Google didn't implement all the TIFF features, maybe they ran out of money).

[lastzero]

It would be very helpful to have file samples available for testing, see our contact page for details:

https://photoprism.app/contact

Edit: Sorry, just saw you already added a ZIP with samples! Thank you :)

[lastzero]

@iwinstar @CDeLeon94 @maxammann Since we added support for the ImageMagick "convert" command to support vector formats (see issue #2207), it is possible that previously unsupported TIFF files will work now.

The upcoming preview build 230213-32483cc88 can be used for testing. Your help is much appreciated!