Thumbs: Skip creating redundant files to save disk space

[CaptnSeraph]

When setting static size limit to for example maximum, an original with size 1333x2000 results in thumbnails of that size being generated but labelled as 4096x4096_fit and 7680x4320_fit

This is resulting in redundant storage of full size images that should be served as full size images once the original image maximum resolution is reached in thumbnail size.

the thumbnail creation process should really be checking the original image maximum resolution and then only creating thumbnails below that resolution

even if this is to allow for thumbnails to be created of the same size as the original (or the next largest thumbnail size as appropriate) at a higher level of compression, there is no need to create thumbnails that are duplicated but still at the same size, as in my example, the 2560x1600_fit is 25% the disk size of the original image

205kb 2560x1600_fit (actual resolution 1066x1600)
876kb 1333x2000 original
834kb 4096x4096_fit (actual resolution 1333x2000)
834kb 7680x4320_fit (actual resolution 1333x2000)

it makes no sense to keep the two thumbnails in this instance (and probably any other instance where a jpg is being recompressed, it may be different for RAW images, but i doubt that going above original resolution more than once is warranted)

[lastzero]

Most photographic images will be larger than typical thumbs & screens. You are right in that the current implementation wastes storage with small original JPEGs. It's a known limitation.

We will address it when done with multi-user support as our small team can't work on everything at the same time.

Also, it's possible to upscale small originals in a way that preserves details on larger screens. Just hasn't been implemented yet. There's a GitHub Issue or Discussion for this. Couldn't find it spontaneously, but we're not working today and have friends visiting. Maybe you find and reference it as it then can make sense 👍

[CaptnSeraph]

do you mean this?

#1856

If there was a deep zoom toggle i think this issue wouldnt be a problem as i could set a nice low thumbnail size i was content with and then enable "full resolution" via a toggle in the viewer but im trying to understand exactly how the thumbnail dynamic resolution works right now because i dont seem to be able to get good high resolution images out without downloading, im usually limited to vertical resolution

also - go enjoy the new year, theres no rush.

[lastzero]

Yes. We're also going to work on the viewer. One step at a time :)

[centralhardware]

thumbnails and original files should not be on the same disks. It is logical to place the thumbnails on a fast disk, while the original files can be located on the hdd. so this optimization may result in slowdowns for some number of users.