Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Album names starting with a number cannot be found #1994

Closed
graciousgrey opened this issue Feb 1, 2022 · 4 comments
Closed

Search: Album names starting with a number cannot be found #1994

graciousgrey opened this issue Feb 1, 2022 · 4 comments
Assignees
Labels
bug Something isn't working released Available in the stable release ux Impacts User Experience

Comments

@graciousgrey
Copy link
Member

Steps to reproduce:

  1. Create an album with a name like "2022-01-02"
  2. Add photos to it
  3. Go to Search and search for albums:"2022-01-02"

Current behavior:

All photos are displayed

Expected behavior:

Only photos of this album must be shown

@thehilll
Copy link

thehilll commented Feb 6, 2022

I think this is not just limited to search for album names (though maybe you didn't mean to imply it was). It seems as if numbers never match a search request. I have a photo that has a subject that appears like this on the Details screen:

["20151225 Christmas",2015,"Events","John"]

When I search for

Subject: John

it works as expected (returns every photo with "John" in the subject), but if I search for:

Subject: "20151225 Christmas"

I get everything that includes the word "Christmas" (e.g. "20141225 Christmas" as well) returned

If I search for either of:

Subject: 2015
Subject: "2015"

I get nothing, even though that number/word by itself is in the subject list.

@graciousgrey
Copy link
Member Author

The subject search filter is only looking for matches in people(=subjects) see https://docs.photoprism.app/user-guide/organize/search/#search-filter-overview

I admit it's a bit confusing.

There is no dedicated search filter for the subject from the details tab for performance reasons (will be improved later). It is covered by the full-text search (which ignores number).

For now you could search year:2015 month:12 day:25 Christmas

@thehilll
Copy link

thehilll commented Feb 8, 2022

Thanks for the explanation.

@lastzero lastzero added the ux Impacts User Experience label Mar 6, 2022
@lastzero lastzero added the in-progress Somebody is working on this label Mar 24, 2022
lastzero added a commit that referenced this issue Mar 24, 2022
Camera and lens can now also be searched by name. Escaping and parsing
of albums has been improved so that albums whose names start with and/or
contain numbers will be found.
@lastzero lastzero added please-test Ready for acceptance test and removed in-progress Somebody is working on this labels Mar 24, 2022
@lastzero lastzero changed the title Search: Album search filter does not work with numbers Search: Album names starting with a number cannot be found Mar 24, 2022
lastzero added a commit that referenced this issue Mar 28, 2022
Adds comment "Needs review, variable number of results." instead.
lastzero added a commit that referenced this issue Apr 3, 2022
Improves readability and maintainability.
@rabotond
Copy link

Tested.
Seems to be fixed, indeed.

@graciousgrey graciousgrey added released Available in the stable release and removed please-test Ready for acceptance test labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in the stable release ux Impacts User Experience
Projects
Status: Release 🌈
Development

No branches or pull requests

4 participants