Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Skip RAW files by default when downloading photos and albums #2234

Closed
lastzero opened this issue Apr 10, 2022 · 5 comments
Closed

UX: Skip RAW files by default when downloading photos and albums #2234

lastzero opened this issue Apr 10, 2022 · 5 comments
Assignees
Labels
enhancement Refactoring, improvement or maintenance task released Available in the stable release ux Impacts User Experience

Comments

@lastzero
Copy link
Member

lastzero commented Apr 10, 2022

As a user with RAW files, I don't want them to be downloaded by default when I click Download All as I only use JPEGs for sharing.

This adds a hidden download.raw = false setting that you can manually set to true in settings.yml until we implement a user interface for it.

Related Code:

Related Issues:

@lastzero lastzero self-assigned this Apr 10, 2022
@lastzero lastzero added enhancement Refactoring, improvement or maintenance task ux Impacts User Experience labels Apr 10, 2022
lastzero added a commit that referenced this issue Apr 10, 2022
Signed-off-by: Michael Mayer <michael@liquidbytes.net>
@lastzero lastzero added the please-test Ready for acceptance test label Apr 10, 2022
@lastzero
Copy link
Member Author

Started a new preview build for testing:

https://docs.photoprism.app/release-notes/#development-preview

@lastzero lastzero changed the title UX: Skip RAW files by default when clicking Download All UX: Skip RAW files by default when downloading photos Apr 11, 2022
@lastzero lastzero changed the title UX: Skip RAW files by default when downloading photos UX: Skip RAW files by default when downloading albums and photos Apr 11, 2022
@lastzero lastzero changed the title UX: Skip RAW files by default when downloading albums and photos UX: Skip RAW files by default when downloading photos and albums Apr 11, 2022
lastzero added a commit that referenced this issue Apr 11, 2022
Signed-off-by: Michael Mayer <michael@liquidbytes.net>
lastzero added a commit that referenced this issue Apr 15, 2022
Extends DownloadSettings with 4 additional options:
- Name: File name pattern for downloaded files (existed)
- Disabled: Disables downloads
- Originals: Only download files stored in "originals" folder
- MediaRaw: Include RAW image files
- MediaSidecar: Include metadata sidecar files (JSON, XMP, YAML)
@lastzero
Copy link
Member Author

Last commit extends the DownloadSettings struct with 4 additional options (evaluated in the front- and backend when starting a download or creating a ZIP file):

  • Name: File name pattern for downloaded files (was there before)
  • Disabled: Disables downloads
  • Originals: Only download files stored in the "originals" folder
  • MediaRaw: Include RAW image files
  • MediaSidecar: Include metadata sidecar files (JSON, XMP, YAML)

You can change these settings in the config/settings.yml file (may require a restart):

Download:
  Name: file
  Disabled: false
  Originals: true
  MediaRaw: false
  MediaSidecar: false

A user interface will be implemented at a later time, as we currently do not have additional resources available. Thanks for your support and patience!

@korikori
Copy link

Hi, for an iPhone user, the default options after this change lead to the following:

  • only download HEIF files;
  • won't download JPEG files.

Settings the Originals option to false brought back the JPEG downlods. If you could add an option to disable HEIF downloads, or add them to the option that disables RAW downloads, that would be great.

@graciousgrey
Copy link
Member

If you could add an option to disable HEIF downloads, or add them to the option that disables RAW downloads, that would be great.

I would rather not include it in disable RAW as HEIF is not a raw format. Feel free to open a new feature request for a disable HEIF download option

@korikori
Copy link

Thanks for your reply. I don't insist on this option, I only mentioned that as it changed the default behavior for me.

@lastzero lastzero moved this to Released 🌈 in Roadmap 🚀✨ Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Refactoring, improvement or maintenance task released Available in the stable release ux Impacts User Experience
Projects
Status: Release 🌈
Development

No branches or pull requests

3 participants