Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs: Omission of repeated messages and minimum level for frontend viewer #2335

Closed
lastzero opened this issue May 20, 2022 · 0 comments
Closed

Logs: Omission of repeated messages and minimum level for frontend viewer #2335

lastzero opened this issue May 20, 2022 · 0 comments
Assignees
@lastzero
Labels
enhancement Refactoring, improvement or maintenance task released Available in the stable release

Comments

@lastzero
Copy link
Member

lastzero commented May 20, 2022 •
edited
Loading

As a user or developer with trace mode enabled, I don't want debug logs and repeated messages sent to the user interface to limit performance overhead and prevent feedback loops when the websocket connection has problems.

  • Since log messages are forwarded to the frontend via websockets, this can lead to feedback loops if something is wrong with the websockets, e.g. if a proxy is misconfigured.
  • These changes will also prevent all debug and trace messages from being sent to the frontend, as they cause a lot of traffic and can contain sensitive information.
@lastzero lastzero added the bug Something isn't working label May 20, 2022
@lastzero lastzero self-assigned this May 20, 2022
lastzero added a commit that referenced this issue May 20, 2022
@lastzero
Logs: Prevent feedback loops by omitting repeated messages #2335
2de1e33 
This also prevents debug and trace messages to be sent to the frontend.
@lastzero lastzero changed the title Logs: Prevent feedback loops by omitting repeated messages Logs: Prevent potential feedback loops by omitting repeated messages May 20, 2022
@lastzero lastzero added enhancement Refactoring, improvement or maintenance task and removed bug Something isn't working labels May 20, 2022
@lastzero lastzero changed the title Logs: Prevent potential feedback loops by omitting repeated messages Logs: Omission of repeated messages and log level filter for logs displayed in the frontend May 20, 2022
@lastzero lastzero added the please-test Ready for acceptance test label May 20, 2022
@lastzero lastzero changed the title Logs: Omission of repeated messages and log level filter for logs displayed in the frontend Logs: Omission of repeated messages and log level filter for frontend viewer May 20, 2022
@lastzero lastzero changed the title Logs: Omission of repeated messages and log level filter for frontend viewer Logs: Omission of repeated messages and min level for frontend viewer May 20, 2022
@lastzero lastzero changed the title Logs: Omission of repeated messages and min level for frontend viewer Logs: Omission of repeated messages and minimum level for frontend viewer May 20, 2022
@graciousgrey graciousgrey added released Available in the stable release and removed please-test Ready for acceptance test labels Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lastzero lastzero

Labels
enhancement Refactoring, improvement or maintenance task released Available in the stable release
Projects
Roadmap 🚀✨
Status: Release 🌈
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lastzero @graciousgrey