Zip: Improve file system rights detection and temporary file handling

[graciousgrey]

Some users reported issues with downloading multiple files at ones: #2530

This might be related to permission issues of the tmp folder

[lastzero]

These changes improve the provisioning of temporary folders and the download handler for zip files.

However, it is still possible that the zip file will be deleted before you can download it, since we remove it at the end of the download request handler (now using defer, but that may not be enough). This is to save disk space.

While it works fine on our own servers, results may depend on how slow the download is - i.e. connection speed and zip file size, as well as how the operating system handles the situation (caching, etc.).

Help with testing and any other contributions to solving this issue are welcome!

[lastzero]

Started a new preview build for testing 👍

[rickysarraf]

@lastzero That didn't seem to help. I selected 102 photos on my instance and hit download. Below is the log snippet.

photoprism_1  | 2022-07-21T14:27:29.307443977Z time="2022-07-21T14:27:29Z" level=info msg="download: added Processed/PXL_20220630_111356243.jpg as PXL_20220630_111356243.jpg"
photoprism_1  | 2022-07-21T14:27:30.285283545Z time="2022-07-21T14:27:30Z" level=info msg="download: added Processed/VID_20220617_182021.mp4 as VID_20220617_182021.mp4"
photoprism_1  | 2022-07-21T14:27:30.557975873Z time="2022-07-21T14:27:30Z" level=info msg="download: added Processed/VID_20220619_095102.mp4 as VID_20220619_095102.mp4"
photoprism_1  | 2022-07-21T14:27:32.172655111Z time="2022-07-21T14:27:32Z" level=info msg="download: added Processed/VID_20220623_124001.mp4 as VID_20220623_124001.mp4"
photoprism_1  | 2022-07-21T14:27:37.361460625Z time="2022-07-21T14:27:37Z" level=info msg="download: added Processed/VID_20220624_164952.mp4 as VID_20220624_164952.mp4"
photoprism_1  | 2022-07-21T14:27:40.613987619Z time="2022-07-21T14:27:40Z" level=info msg="download: added Processed/VID_20220624_165604.mp4 as VID_20220624_165604.mp4"
photoprism_1  | 2022-07-21T14:27:42.705380618Z time="2022-07-21T14:27:42Z" level=info msg="download: added Processed/VID_20220624_170245.mp4 as VID_20220624_170245.mp4"
photoprism_1  | 2022-07-21T14:27:43.386685607Z time="2022-07-21T14:27:43Z" level=info msg="download: added Processed/VID_20220624_170426.mp4 as VID_20220624_170426.mp4"
photoprism_1  | 2022-07-21T14:27:43.944335818Z time="2022-07-21T14:27:43Z" level=info msg="download: added Processed/VID_20220624_170640.mp4 as VID_20220624_170640.mp4"
photoprism_1  | 2022-07-21T14:27:44.579857721Z time="2022-07-21T14:27:44Z" level=info msg="download: added Processed/VID_20220624_213713.mp4 as VID_20220624_213713.mp4"
photoprism_1  | 2022-07-21T14:27:45.632319018Z time="2022-07-21T14:27:45Z" level=info msg="download: added Processed/VID_20220701_221102.mp4 as VID_20220701_221102.mp4"
photoprism_1  | 2022-07-21T14:27:46.092626716Z time="2022-07-21T14:27:46Z" level=info msg="download: added Processed/MVIMG_20220703_102936.jpg as MVIMG_20220703_102936.jpg"
photoprism_1  | 2022-07-21T14:27:46.092679994Z time="2022-07-21T14:27:46Z" level=info msg="download: created photoprism-download-20220721-142706-2t63wnjg.zip [39.997891187s]"
photoprism_1  | 2022-07-21T14:28:44.512172187Z time="2022-07-21T14:28:44Z" level=error msg="could not find zip file: /tmp/photoprism_6a044b3b/zip/photoprism-download-20220721-142706-2t63wnjg.zip"
photoprism_1  | 2022-07-21T14:28:44.601071717Z time="2022-07-21T14:28:44Z" level=error msg="could not find zip file: /tmp/photoprism_6a044b3b/zip/photoprism-download-20220721-142706-2t63wnjg.zip

The version I'm running is:

Build 220719-58521190b

My host view of tmp is:

rrs@lenovo:/var/tmp/ $ ls -lh / | grep tmp
drwxrwxrwt 107 root root  52K Jul 21 19:08 disk-tmp/
drwxrwxrwt   7 root root  140 Jul 21 20:01 ram-tmp/
drwxrwxrwt   7 root root  140 Jul 21 20:01 tmp/

and container's view of tmp is:

photoprism@220719:/photoprism$ ls -l / | grep tmp
drwxrwxrwt   1 root root        4096 Jul 21 14:26 tmp

[lastzero]

Do you use any network storage like NFS or CIFS / SMB? We'll provide a further improved build shortly.

[lastzero]

It seems that the problem was caused by a download manager:

• cannot download mutliple photos as a zip archive #2530