Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata: Files with an altitude out of range are not indexed #3182

Closed
lastzero opened this issue Feb 9, 2023 · 0 comments
Closed

Metadata: Files with an altitude out of range are not indexed #3182

lastzero opened this issue Feb 9, 2023 · 0 comments
Assignees
Labels
bug Something isn't working metadata Related to Exif, XMP, IPTC & Co. released Available in the stable release

Comments

@lastzero
Copy link
Member

lastzero commented Feb 9, 2023

If a media file's metadata has an altitude value that is out of range, such as 4294967284, indexing fails with logs that look like the following:

2023-01-31 18:37:43 ERRO index: failed adding main jpg file 'Misc Photo/2013/2013-08-25_15-54_06.JPG'
2023-01-31 18:37:43 ERRO index: %!s() in 'Misc Photo/2013/2013-08-25_15-54_06.JPG' (find or create photo)
2023-01-31 18:37:43 INFO index: matched 1 label with 2013-08-25_15-54_06.JPG [727.48731ms]

This is probably because Go uses a 64-bit integer, while MariaDB uses a 32-bit integer. We will add a range check (about the diameter of the earth) to prevent this. PhotoPrism defaults to an altitude of 0 in this case.

@lastzero lastzero added the bug Something isn't working label Feb 9, 2023
@lastzero lastzero self-assigned this Feb 9, 2023
@lastzero lastzero added the metadata Related to Exif, XMP, IPTC & Co. label Feb 9, 2023
lastzero added a commit that referenced this issue Feb 9, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero added the please-test Ready for acceptance test label Feb 9, 2023
@graciousgrey graciousgrey added tested Changes have been tested successfully and removed please-test Ready for acceptance test labels Apr 24, 2023
@graciousgrey graciousgrey added released Available in the stable release and removed tested Changes have been tested successfully labels May 3, 2023
@lastzero lastzero moved this to Released 🌈 in Roadmap 🚀✨ Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working metadata Related to Exif, XMP, IPTC & Co. released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

2 participants