-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JPEG: Support panoramas taken with a Samsung S21 #3363
Comments
Yeah, the problem is probably that the upload is indeed successful, but the indexing fails. We don't yet know if all files can be indexed properly with all metadata, etc. at the time the success message is displayed. However, you should find error or warning logs under Library > Errors? |
What would be a good solution (apart from never having problems with indexing)? Show another message that says "Sorry, upload was not successful, ignore the previous information"? |
Of course, we will also take a look at improving the JPEG reader, but due to the many other tasks, I can't promise a quick solution. Ideally a contributor can help with this! Thank you :) |
@lastzero I've seen you've changed the title to "UX: Warn user if upload was successful but indexing failed 1". That said, I did open a separate issue to track that specific problem here: #3371. Can you edit the labels accordingly please as this issue isn't about UX.
Yup that'll be part of the new issue I've created to track the UX issue but it's not what I'm after here. In that very specific case, I'd just like not to have a crash in the first place and being able to upload my panoramas without running a bunch of commands with image magick to fix them upstream. What I'm after would be to have this fix included so that the bad images are not crashing.
Correct. But because it appears as successful, I'm not tempted by any mean to open the logs. I only did because by chance I noticed that the album had a different number of pictures than what I had originally. But let's move UX discussion to the new issue.
I'll reference that comment in the new issue and answer here.
Awesome 🔥. Hopefully it's limited to this little fix 🤞
I understand. While I'm not in a position to help, I'm a developer and I know what a backlog is like 🙃. If you need any more info about this or if you've got any issue to repro, do ping me. Happy to help out. Last but not least, as I see this issue already have a few ":+1:", in case someone is interested in a temporary fix to go pretty much automatically, through a lot of pics, I've explained how to do that here. |
This should be fixed with However, we should take a look at the indexing performance, because it seems slower now, at least for files with errors. |
Signed-off-by: Michael Mayer <michael@photoprism.app>
I just tried the preview version and I can confirm with my test image above that this is now fixed! 🎉 Thanks a lot |
@maxime1992 While the changes did not help to read the "broken" JPEGs without re-encoding them, they broke the repair mechanism that we implemented for Samsung panoramas. I've just added (yet another) fix for this, see: An updated preview build will be available for testing soon! |
1. What is not working as documented?
Latest release includes improvement for broken pictures.
But all the panoramas taken with a Samsung S21 are still appearing as "upload successful" while they're actually not.
2. How can we reproduce it?
Steps to reproduce the behavior:
Download this image (just as a sanity check in case github does any kind of processing, the md5 checksum should be
75171ad4f47a883b97e73bced03a29c7
):3. What behavior do you expect?
Being able to upload my panorama successfully
4. What could be the cause of your problem?
Looking at related issues #1944, #1407, #2463 and this comment in particular #1407 (comment), I suspect the issue is in the golang repo mentionned. BUT, there seem to be a 1 line fix when consuming the picture and I'm hoping it can be as simple as this on Photoprism side to fix this for now and eventually remove that useless 1 line fix once it's fixed upstream. But the upstream issue has been open for a while and it'd be lovely to have that fix available in Photoprism meanwhile. I know it's not ideal, but if it's really a 1 line fix, it'd be tremendously helpful 🙏
And for refence, I'm creating this new issue as suggested here.
5. Can you provide us with example files for testing, error logs, or screenshots?
Testing file uploaded above.
The kind of logs I'm getting is this:
6. Which software versions do you use?
(a) PhotoPrism Architecture & Build Number: AMD64, ARM64, ARMv7,...
AMD64, build
230502-c405f6eff
(b) Database Type & Version: MariaDB, MySQL, SQLite,...
MariaDB 10.11 as suggested in the release note
(c) Operating System Types & Versions: Linux, Windows, Android,...
Linux / official Photoprism docker image
(d) Browser Types & Versions: Firefox, Chrome, Safari on iPhone,...
Chrome
(e) Ad Blockers, Browser Plugins, and/or Firewall Software?
Yes but works fine for any other picture
The text was updated successfully, but these errors were encountered: