JPEG: Support panoramas taken with a Samsung S21

[maxime1992]

1. What is not working as documented?

Latest release includes improvement for broken pictures.

But all the panoramas taken with a Samsung S21 are still appearing as "upload successful" while they're actually not.

2. How can we reproduce it?

Steps to reproduce the behavior:

Download this image (just as a sanity check in case github does any kind of processing, the md5 checksum should be 75171ad4f47a883b97e73bced03a29c7):

• Try to upload it on Photoprism
• At the end, notice that whether you get a success or an error for the upload, the file won't be in your gallery

3. What behavior do you expect?

Being able to upload my panorama successfully

4. What could be the cause of your problem?

Looking at related issues #1944, #1407, #2463 and this comment in particular #1407 (comment), I suspect the issue is in the golang repo mentionned. BUT, there seem to be a 1 line fix when consuming the picture and I'm hoping it can be as simple as this on Photoprism side to fix this for now and eventually remove that useless 1 line fix once it's fixed upstream. But the upstream issue has been open for a while and it'd be lovely to have that fix available in Photoprism meanwhile. I know it's not ideal, but if it's really a 1 line fix, it'd be tremendously helpful 🙏

And for refence, I'm creating this new issue as suggested here.

5. Can you provide us with example files for testing, error logs, or screenshots?

Testing file uploaded above.

The kind of logs I'm getting is this:

import: failed creating thumbnails for 2021/11/20211128_141554_7B99F85D.jpg (EOF while decoding)

6. Which software versions do you use?

(a) PhotoPrism Architecture & Build Number: AMD64, ARM64, ARMv7,...

AMD64, build 230502-c405f6eff

(b) Database Type & Version: MariaDB, MySQL, SQLite,...

MariaDB 10.11 as suggested in the release note

(c) Operating System Types & Versions: Linux, Windows, Android,...

Linux / official Photoprism docker image

(d) Browser Types & Versions: Firefox, Chrome, Safari on iPhone,...

Chrome

(e) Ad Blockers, Browser Plugins, and/or Firewall Software?

Yes but works fine for any other picture

[lastzero]

Yeah, the problem is probably that the upload is indeed successful, but the indexing fails. We don't yet know if all files can be indexed properly with all metadata, etc. at the time the success message is displayed. However, you should find error or warning logs under Library > Errors?

[lastzero]

What would be a good solution (apart from never having problems with indexing)? Show another message that says "Sorry, upload was not successful, ignore the previous information"?

[lastzero]

Of course, we will also take a look at improving the JPEG reader, but due to the many other tasks, I can't promise a quick solution. Ideally a contributor can help with this! Thank you :)