People: Face clusters missing after renaming and merging

[pjft]

1. What is not working as documented?

Renaming/merging face clusters can make faces no longer show up on Recognized people faces.

2. How can we reproduce it?

Steps to reproduce the behavior:

1. Go to 'New' faces
2. Label people clusters, for instance "Manuel".
3. Mistakenly label one with "man" (had lots of clusters and was searching by name. Pressed "enter" assuming it would select "Manuel", but instead created a new cluster "man").
4. Click the "man" cluster label in that same screen, and rename it to "Manuel".

The "Manuel" cluster doesn't add these new clustered faces to it, and total stays the same.

Log messages are unexpected:

2023-05-17 22:18:20 INFO subject: person Manuel flagged as missing
2023-05-17 22:18:16 INFO changes successfully saved
2023-05-17 22:18:15 INFO subject: added person man

I expected "man" to be flagged as missing, not "Manuel".

Afterwards, I renamed "Manuel" to "man", to see if it changed anything, and then back to Manuel, to see if it'd absorb the old photos.

3. What behavior do you expect?

The "Manuel" cluster adds the new clustered faces to it, showing up in the faces total. Also, "Manuel" shows up in the autocomplete suggestions.

4. What could be the cause of your problem?

Potentially incorrectly flagging person as missing.

I tried both faces audit --fix and faces optimize, but nothing changed. I have a backup, and I suppose I could go directly to the database and try to fix things, but I'd rather not in case I break anything else.

5. Can you provide us with example files for testing, error logs, or screenshots?

This was when I made the mistake. I added "man", and then renamed to "Manuel". "Manuel" is flagged as missing, though it shouldn't have - there were already plenty of faces with that correct label:

2023-05-17 22:18:20 INFO subject: person Manuel flagged as missing
2023-05-17 22:18:16 INFO changes successfully saved
2023-05-17 22:18:15 INFO subject: added person man

Afterwards, whenever I try to add Manuel or man (to see if I could fix it?), I just get these:

-- adding man:

2023-05-17 23:32:14 INFO subject: person Manuel flagged as missing
2023-05-17 23:32:14 INFO subject: restoring person man

-- adding Manuel:

2023-05-17 23:31:27 INFO changes successfully saved
2023-05-17 23:31:26 INFO subject: person man flagged as missing
2023-05-17 23:31:26 INFO subject: restoring person Manuel

6. Which software versions do you use?

(a) PhotoPrism Architecture & Build Number: ARM64
(b) Database Type & Version: MariaDB
(c) Operating System Types & Versions: Linux Debian
(d) Browser Types & Versions: Chrome
(e) Ad Blockers, Browser Plugins, and/or Firewall Software? Yes.

Build 230514-0b780defb

7. On what kind of device is PhotoPrism installed?

(a) Device / Processor Type: Raspberry Pi 4
(b) Physical Memory & Swap Space in GB: 8GB
(c) Storage Type: HDD
(d) Anything else that might be helpful to know? Not much.

[lastzero]

I just tested this on our demo and it seems to work as expected...

Step 1

Step 2

Result

Please note: The exact behavior will also depend on the specific faces due to conflict detection. In the worst case, e.g. if they may be identical twins, it could be that automatic recognition is disabled for specific faces as this was recently requested by a user.

[pjft]

Hi Michael!

You're right, there's the demo environment - perfect :)

Ok, I got it in that state right now fairly easily - if you go there (assuming it doesn't get recreated periodically), you'll find the moustached man and the Deutscher Filmpreis pink lady picture not showing in the face clusters.

What I did - after resetting all the faces last night by removing all the face mappings, and letting them re-cluster overnight, is the following:

-- always in the "New" People screen:

1. Click text box for man. Type "Manuel" and press enter.

2023-05-18 07:01:04 INFO subject: added person Manuel
2023-05-18 07:01:04 INFO changes successfully saved

2. Click text box for pink lady. Type "man". Press enter.

2023-05-18 07:01:07 INFO subject: added person man
2023-05-18 07:01:07 INFO changes successfully saved

3. Click "man" label, delete it and type Manuel. Press enter. Notice how it doesn't ask if we want to merge the clusters (just in case that's a symptom of the correct logic flow not being followed.

2023-05-18 07:01:13 INFO subject: person Manuel flagged as missing
2023-05-18 07:01:13 INFO changes successfully saved

Now, navigate to the Recognized screen to confirm only one cluster shows up. Refresh the page so total gets updated.

4. Click the "Manuel" label to edit it. Rename "Manuel" to man, to attempt to recover the pictures that may have been lost in the renaming. Cluster now disappears from view.

2023-05-18 07:01:41 INFO subject: restoring person man
2023-05-18 07:01:41 INFO subject: person man flagged as missing

Get scared. Refresh the page. Cluster is actually there. Phew!

5. Click the "man" label, and rename "man" to Manuel to get the actual name you intended back. Cluster disappears forever.

2023-05-18 07:01:54 INFO person saved
2023-05-18 07:01:54 INFO subject: person Manuel flagged as missing

So, what's the current state now:

• If you search for "man", you will find the pictures for the "man" label face, even though it had supposedly been renamed Manuel.
• If you open the picture, you will see the face labeled "man".
• The face label and cluster does not show up on the People tab.

If you can't replicate it I'll gladly reset it again and record the interaction, but hopefully this is helpful - and, assuming that it doesn't get recreated, you'll be able to check the state I got mine in.

I am thinking that I may fix it if I end up just manually removing the label from all the "Manuel" faces, one by one, and hoping that it clusters again, but since there are a lot of them, I was hoping that there'd be an easier way somehow. If not, well, it's ok. I'll just go through them one by one. In fact, I might, even though there are 700+ labels.

If not, I have a database backup from before this happened that I can just restore.

Let me know if this helps, and thanks for the prompt response!

[pjft]

I just visited the demo environment and it was changed, so I assume it was regenerated or something was undone on the face clusters.

Photoprism.mp4

Still, I recorded a small video of me doing it again, in case it helps - with the logs window on the side.

Hope it helps.

[graciousgrey]

Thank you for the recording :)

[pjft]

By all means, thank you for the message!

For what it's worth, a few more notes:

• After manually going through the 700+ records of the face and "ejecting them" from the cluster, they finally all show up in the "New" face clusters.
• However, it seems that the label "Manuel" is still unusable. I tested adding a random face to "Manuel" and it still didn't show up as listed. Also, even though I labeled it "Manuel", it was automatically renamed as "man".

Hope this helps. I ended up confirming that there were no faces and markers tied to those 2 subject ids, and deleted them in the database.

I could also just restore the previous database backup but to be honest I'd rather avoid having to go tag my entire photo set if I can avoid it :)

[graciousgrey]

We will have a look at this next week.

[pjft]

Of course, no urgency whatsoever on my end, and thank you for engaging here - just wanted to report it in case it'd be helpful. I ended up recovering the previous database backup and decided to relabel the pictures again, so no problem there.

If there's anything I can do to help, though, let me know.

The only thing I noticed, if it helps, is that these labels still had a deleted_at value their entry in the subjectstable, so it might be something as simple as seeing if that needs to be unset.

select * from subjects where subj_name like 'man%' limit 5;

was the query I was using to check that.

Have a great weekend! :)