Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folders: Find all matching albums, even if a query contains spaces #3441

Closed
aaronrudkin opened this issue Jun 1, 2023 · 2 comments
Closed
Assignees
Labels
bug Something isn't working released Available in the stable release

Comments

@aaronrudkin
Copy link

1. What is not working as documented?

As per the issue title, some searches in the folder facet do not return correct results in an under-inclusive way. I am not precisely sure what the issue is, but generally very vague / single word searches return results, and exactly correct searches return results, but medium detail searches do not.

I have a folder entitled "2011 Joy of Cooking Calendar Photos" which is located at the path "Albums to Sort/2011 Joy of Cooking Calendar Photos" relative to the root.

Here are a series of search queries and whether or not the folder comes up:
"2011 joy of cooking calendar photos" 👍
"2011 joy of cooking calendar" 👍
"joy of cooking calendar" ❌
"joy of cooking" ❌
"cooking calendar" ❌
"joy" 👍
"calendar" 👍
"cooking" 👍
"of" 👍
"2011" 👍

I have a second folder entitled "2008 June Emily Concert" which is located at the path "Albums to Sort/2008 June Emily Concert"

2008 june emily 👍
2008 june 👍
2008 emily ❌
2008 concert ❌
june emily ❌
emily concert ❌
june concert ❌
concert 👍
emily 👍
june 👍
2008 👍

On your demo site, you have a folder called "German film awards 2012" and "film awards" will not find this as a result.

2. How can we reproduce it?

It is unclear to me if this bug emerges as a result of a more sophisticated edge case in terms of the search indexing, but I imagine given that it's folder searching, that this is easy to reproduce by simply creating a folder with that name and doing the search, and as I said it's reproducible on the demo site.

3. What behavior do you expect?

In general, if I am searching for a folder, and I enter search keywords that are contained in the folder name, the folder should be a result for the search query.

4. What could be the cause of your problem?

My guess is it's an issue with either how folder names are indexed or how the search scores results and discards insufficiently high quality results.

5. Can you provide us with example files for testing, error logs, or screenshots?

Attached screenshots, though as I said you can reproduce a version of this on your demo site.

proof no result
proof exists

6. Which software versions do you use?

ARM64 on Synology, MariaDB, not browser specific. Build 230514-0b780defb for my local install though it can be reproduced on your demo site.

This is a low urgency bug (since it can be worked around by simply making the search more precise or vague). I vacillated as to whether this was a bug (because these results are obviously unexpected and incorrect) or a feature request (because perhaps it is known that the folder facet doesn't have robust searching options and I'm asking for something to be built out) -- but I appreciate your time regardless and hope this report is useful.

@aaronrudkin aaronrudkin added the bug Something isn't working label Jun 1, 2023
@lastzero lastzero self-assigned this Jun 1, 2023
lastzero added a commit that referenced this issue Jun 1, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero changed the title Search: Folder facet search fails to find partial match (e.g. "film awards" will not find "German film awards 2012" folder) Folders: Find all matching albums, also for search strings containing spaces Jun 1, 2023
@lastzero lastzero changed the title Folders: Find all matching albums, also for search strings containing spaces Folders: Find all matching albums, even if a query contains spaces Jun 1, 2023
@lastzero lastzero added the please-test Ready for acceptance test label Jun 1, 2023
@lastzero
Copy link
Member

lastzero commented Jun 1, 2023

I've changed the search query, so this issue is hopefully resolved. An updated development preview will be available for testing soon! Looking forward to your feedback :)

You can also test this in our public demo, which is based on the latest preview build by default:

https://demo.photoprism.app/library/folders?q=film%20AWARD&order=name

@lastzero lastzero assigned aaronrudkin and unassigned lastzero Jun 1, 2023
@aaronrudkin
Copy link
Author

Can confirm this works both in my own instance updated to 230601 and on the demo site, so looks like this is solved. LGTM. Feel free to close :)

@lastzero lastzero added tested Changes have been tested successfully released Available in the stable release and removed please-test Ready for acceptance test tested Changes have been tested successfully labels Jun 2, 2023
@lastzero lastzero closed this as completed Jun 3, 2023
@lastzero lastzero moved this to Released 🌈 in Roadmap 🚀✨ Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

2 participants