Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Albums: Invalid entries must be automatically flagged as missing #3481

Closed
lastzero opened this issue Jun 15, 2023 · 0 comments
Closed

Albums: Invalid entries must be automatically flagged as missing #3481

lastzero opened this issue Jun 15, 2023 · 0 comments
Assignees
Labels
bug Something isn't working released Available in the stable release ux Impacts User Experience

Comments

@lastzero
Copy link
Member

When a record in the photos table no longer exists, the corresponding record in the photos_albums table is not flagged as missing, because the corresponding query only checks if photos.deleted_at is not NULL.

To fix the album entry counts displayed in the UI, the query must additionally check if the photos_albums.photo_uid exists in the photos table or if it is unknown e.g. after a photo has been permanently deleted with the photoprism purge command or manually with SQL.

@lastzero lastzero added the bug Something isn't working label Jun 15, 2023
@lastzero lastzero self-assigned this Jun 15, 2023
@lastzero lastzero moved this to Development 🐝 in Roadmap 🚀✨ Jun 15, 2023
lastzero added a commit that referenced this issue Jun 15, 2023


Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this issue Jun 15, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero added ux Impacts User Experience please-test Ready for acceptance test labels Jun 15, 2023
@lastzero lastzero moved this from Development 🐝 to Preview 🐳 in Roadmap 🚀✨ Jun 15, 2023
@lastzero lastzero changed the title Albums: Deleted and/or unknown pictures must be flagged as missing Albums: Deleted and/or unknown entries must be flagged as missing Jun 15, 2023
@lastzero lastzero changed the title Albums: Deleted and/or unknown entries must be flagged as missing Albums: Invalid entries must be automatically flagged as missing Jun 19, 2023
@graciousgrey graciousgrey added tested Changes have been tested successfully and removed please-test Ready for acceptance test labels Jun 23, 2023
@lastzero lastzero moved this from Preview 🐳 to Released 🌈 in Roadmap 🚀✨ Jun 25, 2023
@lastzero lastzero added released Available in the stable release and removed tested Changes have been tested successfully labels Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in the stable release ux Impacts User Experience
Projects
Status: Release 🌈
Development

No branches or pull requests

2 participants