Skip to content

Live Photos: Sidecar video file dimensions are indexed incorrectly #3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
graciousgrey opened this issue Jul 20, 2023 · 1 comment
Closed

Live Photos: Sidecar video file dimensions are indexed incorrectly #3559

graciousgrey opened this issue Jul 20, 2023 · 1 comment
Assignees
@lastzero
Labels
bug Something isn't working metadata Related to Exif, XMP, IPTC & Co. released Available in the stable release tested Changes have been tested successfully video Video Formats, Transcoding, FFmpeg, Streaming & Co

Comments

@graciousgrey
Copy link
Member

1. What is not working as documented?

On the files tab of the edit dialog a wrong video size is displayed.

2. How can we reproduce it?

Steps to reproduce the behavior:

  1. Index a live photo, e.g. IMG_123.heic ("ImageSize": "4032x3024") + IMG_123.mov ("ImageSize": "1920x1440").
  2. Go to the files tab of the edit dialog

For the .heic file, the correct size is displayed. For the .mov file, the size of the .heic file is displayed.

3. What behavior do you expect?

Display the correct size for all files.
@graciousgrey graciousgrey added the bug Something isn't working label Jul 20, 2023
@graciousgrey graciousgrey changed the title Videos: Wrong video size is displayed on the files tab of live photos Videos: Incorrect video size is displayed on the Files tab of Live Photos Jul 20, 2023
@lastzero lastzero changed the title Videos: Incorrect video size is displayed on the Files tab of Live Photos Videos: Incorrect size is displayed for Live Photos in the Files tab Aug 1, 2023
@lastzero lastzero self-assigned this Aug 1, 2023
@lastzero lastzero moved this to Development 🐝 in Roadmap 🚀✨ Aug 1, 2023
lastzero added a commit that referenced this issue Aug 15, 2023
@lastzero
Metadata: Add test for mov video JSON files #3559
5822a26 
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this issue Aug 15, 2023
@lastzero
Live Photos: Show correct image and video dimensions #3559
3f6cb27 
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero
Copy link
Member

With these changes, the correct file properties should be displayed after reindexing all affected files.

@lastzero lastzero added please-test Ready for acceptance test metadata Related to Exif, XMP, IPTC & Co. video Video Formats, Transcoding, FFmpeg, Streaming & Co labels Aug 15, 2023
@lastzero lastzero moved this from Development 🐝 to Preview 🐳 in Roadmap 🚀✨ Aug 15, 2023
lastzero added a commit that referenced this issue Aug 15, 2023
@lastzero
Entities: Update file_test.go #3559
3581aaf 
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this issue Aug 15, 2023
@lastzero
Live Photos: Update cards.vue #3559
3212724 
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero changed the title Videos: Incorrect size is displayed for Live Photos in the Files tab Live Photos: Wrong dimensions are displayed for sidecar video files Aug 16, 2023
@lastzero lastzero changed the title Live Photos: Wrong dimensions are displayed for sidecar video files Live Photos: Sidecar video file dimensions are indexed incorrectly Aug 16, 2023
@graciousgrey graciousgrey added tested Changes have been tested successfully and removed please-test Ready for acceptance test labels Aug 17, 2023
@lastzero lastzero mentioned this issue Aug 18, 2023
Merged
lastzero added a commit that referenced this issue Aug 18, 2023
@lastzero
Videos: Improve code comments in index_mediafile.go #926 #3588 #3559
69f1592 
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this issue Aug 18, 2023
@lastzero
Videos: Refactor File.UpdateVideoInfos() method #926 #3588 #3559
c6bb28f 
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this issue Aug 18, 2023
@lastzero
Videos: Improve code comments in index_mediafile.go #926 #3588 #3559
f15ca1d 
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this issue Sep 3, 2023
@lastzero
Index: Set appearance of video files based on their primary image #3559
c0ee909 
Signed-off-by: Michael Mayer <michael@photoprism.app>
@graciousgrey graciousgrey added the released Available in the stable release label Sep 24, 2023
@graciousgrey graciousgrey moved this from Preview 🐳 to Released 🌈 in Roadmap 🚀✨ Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lastzero lastzero

Labels
bug Something isn't working metadata Related to Exif, XMP, IPTC & Co. released Available in the stable release tested Changes have been tested successfully video Video Formats, Transcoding, FFmpeg, Streaming & Co
Projects
Roadmap 🚀✨
Status: Release 🌈
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lastzero @graciousgrey