Skip to content

Albums: Preview image missing when sharing album links #3658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
graciousgrey opened this issue Aug 21, 2023 Discussed in #3452 · 6 comments
Closed

Albums: Preview image missing when sharing album links #3658

graciousgrey opened this issue Aug 21, 2023 Discussed in #3452 · 6 comments
Assignees
Labels
bug Something isn't working released Available in the stable release tested Changes have been tested successfully

Comments

@graciousgrey
Copy link
Member

Discussed in #3452

Originally posted by dror3go June 5, 2023
I'm not sure if this is a bug, a change in config that I've missed, a change in behavior or what, but in the past when I shared a link to an album in WhatsApp/Telegram/etc. There was a preview with thumbnails of several pictures from the album.
Somewhere in the past few releases this changed, and the preview shows only the album's name.

Is that the new desired behavior?

@graciousgrey graciousgrey added the bug Something isn't working label Aug 21, 2023
@graciousgrey graciousgrey moved this to Development 🐝 in Roadmap 🚀✨ Aug 21, 2023
@lastzero lastzero changed the title Albums preview links lack thumbnails Albums: Preview image missing when sharing album links Aug 21, 2023
lastzero added a commit that referenced this issue Aug 21, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero added the please-test Ready for acceptance test label Aug 21, 2023
@lastzero
Copy link
Member

There simply was a / too much in the generated preview image URL. Should be fixed now.

@lastzero lastzero moved this from Development 🐝 to Preview 🐳 in Roadmap 🚀✨ Aug 21, 2023
lastzero added a commit that referenced this issue Aug 21, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero
Copy link
Member

Even after fixing the URL, it's still not displaying the preview image when sharing. I suspect this could be due to the redirect, which is now delayed.

lastzero added a commit that referenced this issue Aug 21, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero
Copy link
Member

I overlooked that path.Join() will break the site URL, so with this change it simply prepends it to the generated path.

@lastzero
Copy link
Member

Our development preview and public demo have been updated. It looks good to me now! 👍

@dror3go
Copy link

dror3go commented Sep 1, 2023

Looks good, thanks a lot!

lastzero added a commit that referenced this issue Sep 8, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero
Copy link
Member

lastzero commented Sep 8, 2023

With these changes, album share preview images are regenerated whenever changes are made. Change detection does not yet work when an album contains a picture that is later made private without being (directly) removed from an album. Manual changes in the database also do not cause the thumbnail cache to be cleared. For this reason, the cached image now also expires after only one hour instead of one day as before.

In addition, the rendering has been improved so that previews now look like Polaroids rather than simple squares:

preview

flowers

lastzero added a commit that referenced this issue Sep 9, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this issue Sep 9, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
graciousgrey added a commit that referenced this issue Sep 11, 2023
@graciousgrey graciousgrey added tested Changes have been tested successfully and removed please-test Ready for acceptance test labels Sep 13, 2023
@graciousgrey graciousgrey added the released Available in the stable release label Sep 24, 2023
@graciousgrey graciousgrey moved this from Preview 🐳 to Released 🌈 in Roadmap 🚀✨ Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in the stable release tested Changes have been tested successfully
Projects
Status: Release 🌈
Development

No branches or pull requests

3 participants