Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download: Select Files and Formats and configure defaults #449

Closed
RAYs3T opened this issue Aug 7, 2020 · 15 comments
Closed

Download: Select Files and Formats and configure defaults #449

RAYs3T opened this issue Aug 7, 2020 · 15 comments
Assignees
Labels
idea Feedback wanted / feature request released Available in the stable release ux Impacts User Experience

Comments

@RAYs3T
Copy link
Contributor

RAYs3T commented Aug 7, 2020

Download of multiple files

So right now whenever you download a single picture, it will download all the files assosiated with this specific one.
This leads to the behavior of downloading a raw+jpeg when you click on the download button.
In firefox for example this gives you two pop-ups to save the file.

In the most situations you only need one type of image. You either want the raw to edit the picture or just the version displayed for whatever.

How about a dropdown?

What about adding a little drop down menu at the side of the button, where you can select what exact file you wish to download?
image

Make the default file type to download an option (later)

This also has great potential to be an option where the user could set its prefered download file type.
Tho I would NOT include this into this issue / PR. That might be something for later.

@lastzero If you're ok with that I would do the changes and throw it in a PR?

@RAYs3T RAYs3T changed the title Handling of downloads - raw+jpeg - Choose the file to download Handling of downloads - raw+jpeg - choose the file to download Aug 7, 2020
@lastzero lastzero added the idea Feedback wanted / feature request label Sep 15, 2020
@lastzero
Copy link
Member

Sorry for the wait! You are right, need to improve this. Selecting a smaller (resampled) size should be possible as well.

Adding a download dialog so that users may select specific file type(s) and size(s) seems necessary. However, this might complicate PhotoPrism for less experienced users as they'll feel unsure what to select.

@MrRaph
Copy link

MrRaph commented Oct 29, 2020

It's the only feature missing in PhotoPrism that lead me to find another software... :(

@graciousgrey
Copy link
Member

Good to know that this feature is important for some users. In the future we plan to have something like a public roadmap/feature voting, so that we gain insights which features are most wanted :)

@graciousgrey graciousgrey changed the title Handling of downloads - raw+jpeg - choose the file to download Download / Choose file type/s for download e.g. RAW and/or JPEG Nov 26, 2020
@lastzero lastzero changed the title Download / Choose file type/s for download e.g. RAW and/or JPEG Download: Select Files and Formats Dec 31, 2020
@shoeper
Copy link

shoeper commented Jan 4, 2021

Sorry for the wait! You are right, need to improve this. Selecting a smaller (resampled) size should be possible as well.

Adding a download dialog so that users may select specific file type(s) and size(s) seems necessary. However, this might complicate PhotoPrism for less experienced users as they'll feel unsure what to select.

Maybe the proposed dropdown could contain very few carefully selected options (depending on object type and available formats) and for more there is an advanced option.

Another option could be to allow adding additional options in the user or system settings.

Too many options would also slow usage down for advanced users and many average users are even overwhelmed by any options. Probably it would be even better to have one default when clicking download without any further options. E.g. jpeg for images, gif (or mp4?) for moving pictures, mp4 for live pictures, mp4 for videos. Just click download and photoprism provides a good option.

@lastzero lastzero removed the unfunded label Jan 18, 2021
lastzero added a commit that referenced this issue Jan 27, 2021
Related issues:
- Configure download name for files and albums #848
- When downloading live photos, zip all the associated files #437
@lastzero
Copy link
Member

lastzero commented Jan 28, 2021

In a first step, downloads have been refactored:

  • When clicking download in the photo viewer or context menu in search results, this will download all media files without sidecar files using their current file name by default. The file name schema can be configured in config/settings.yml - you may choose to let PhotoPrism generate a file name based on the photo title or use the original name (before importing and renaming).
  • In addition you can download single files in the photo edit dialog > Files tab.
  • When downloading albums, RAWs and sidecar files will be excluded. In addition, files will be named using their taken date and the photo title so that they can be viewed in the right order - even without special software that reads their metadata.

@ministryofsillywalks
Copy link

Just ran into this limitation. I made a big selection of photos from the last year that I wanted to make into a calendar. Mix of unedited raws and jpegs.
When I went to download the album I just got the jpeg files and the raws converted to jpegs (which of course were quite off in colour balance)
Now I have to manually download all the raw files so that I can edit them for the printing.
So yeah having the option to download the highest quality or "originals" from an album would be awesome!

@lastzero
Copy link
Member

lastzero commented Dec 1, 2021

Use the regular search with the album:name filter, select all items with long / shift click, and then download using the button in the context menu (bottom right):

https://demo.photoprism.org/browse?view=cards&q=album%3Acalifornia

We'll add yet another config option / select dialog for this in a future release.

@graciousgrey graciousgrey changed the title Download: Select Files and Formats Download: Select Files and Formats and configure defaults Jan 12, 2022
lastzero added a commit that referenced this issue Mar 11, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero self-assigned this Mar 11, 2023
@lastzero lastzero added the ux Impacts User Experience label Mar 11, 2023
lastzero added a commit that referenced this issue Mar 11, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this issue Mar 11, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this issue Mar 11, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this issue Mar 11, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero
Copy link
Member

download-settings

@lastzero lastzero added the please-test Ready for acceptance test label Mar 11, 2023
@lastzero
Copy link
Member

I've started a new preview build for testing. It should be available within the next hour!

lastzero added a commit that referenced this issue Mar 11, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this issue Mar 11, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero
Copy link
Member

lastzero commented Mar 11, 2023

Moved the download settings to the bottom so the map settings don't lose visibility:

download-settings

seeschloss pushed a commit to seeschloss/photoprism that referenced this issue Apr 10, 2023
seeschloss pushed a commit to seeschloss/photoprism that referenced this issue Apr 10, 2023


Signed-off-by: Michael Mayer <michael@photoprism.app>
seeschloss pushed a commit to seeschloss/photoprism that referenced this issue Apr 10, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
seeschloss pushed a commit to seeschloss/photoprism that referenced this issue Apr 10, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
seeschloss pushed a commit to seeschloss/photoprism that referenced this issue Apr 10, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
seeschloss pushed a commit to seeschloss/photoprism that referenced this issue Apr 10, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
seeschloss pushed a commit to seeschloss/photoprism that referenced this issue Apr 10, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@graciousgrey graciousgrey added tested Changes have been tested successfully and removed please-test Ready for acceptance test labels Apr 24, 2023
@graciousgrey graciousgrey added released Available in the stable release and removed tested Changes have been tested successfully labels May 3, 2023
@lastzero lastzero moved this to Released 🌈 in Roadmap 🚀✨ Jun 8, 2023
@DrDonoso
Copy link

DrDonoso commented Feb 7, 2024

Hello @lastzero,

What do you think about a feature that allows which default file extension when downloading?
When I upload a photo with photosync into a folder, it uploads the .HEIC and .MOV for the live photos (make sense to me), so Photoprism is converting it into .HEIC.jpg and .MOV.jpg which is really great (but could be really great to disable transformation .MOV->.jpg). But then with the existant options it is only possible to download:

  • .HEIC, .MOV, .HEIC.jpg, .MOV.jpg (when unselecting everything)
  • .HEIC, .MOV (when selecting Originals option)

It will add a lot of value when using a PWA on an Android Phone (also from other computers) you could download the jpg without going into Edit->Files->Selecting the file->Download which is a bit overwhelming.

I highly appreciate your effort 🥇

Thanks!

@lastzero
Copy link
Member

lastzero commented Feb 7, 2024

@DrDonoso That would probably mean that you would have to treat images and videos differently. Did I understand correctly that you always want to download the original video file, but the JPEG version of images? Or would you prefer to always download (web) compatible formats, i.e. AVC for videos and JPEG for images?

Edit: Note that if you always want to download AVC-encoded videos, they may need to be transcoded first, which takes time and therefore delays the download.

@DocJ-GA
Copy link

DocJ-GA commented May 5, 2024

i think there should be a download jpg or png option with multiple selected so you can easily use them for uploading to a blog or other site that doesn't allow heic.

@mordka
Copy link

mordka commented Dec 30, 2024

As a user I would like to specify file types to download so that I can quickly download only images.

@lastzero
Copy link
Member

@mordka You can change the types of files that are downloaded under Settings > General > Download:

download-settings

However, I believe there is currently no way to specify that you always want a JPEG file, for example, especially since videos, live photos and animations cannot be converted to JPEG. Other types, such as PNG and vector graphics, may only be available as PNG because the transparency would be lost if converted to JPEG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Feedback wanted / feature request released Available in the stable release ux Impacts User Experience
Projects
Status: Release 🌈
Development

No branches or pull requests

9 participants