-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Prefix routes with /library/... so that 404 can be returned for non-existing assets #840
Comments
Routing is performed on the client. There is no simple way the server may know what routes exist in JS - and we can't afford to add much more complexity right now. We may of course implement a 404 page in JS saying "No found, click here to return to home" instead of redirecting to home straight away. Not sure how much value this provides to our users though. |
Ah, that makes sense. While we can't do it for a generic route, we might be to implement a 404 just for non-existent |
It looks like this would be handled here: photoprism/internal/server/routes.go Line 151 in a747cca
|
Also improves migrations and updates the db schema docs. Signed-off-by: Michael Mayer <michael@photoprism.app>
Signed-off-by: Michael Mayer <michael@photoprism.app>
Signed-off-by: Michael Mayer <michael@photoprism.app>
Signed-off-by: Michael Mayer <michael@photoprism.app>
Signed-off-by: Michael Mayer <michael@photoprism.app>
Signed-off-by: Michael Mayer <michael@photoprism.app>
Signed-off-by: Michael Mayer <michael@photoprism.app>
Nobody complained so far, so I'll move ahead and close this as done! |
During development I was requesting a JS file that did not exist. However, it took me a very long time to figure this out because the browser was returning a 200. I thought I had Babel configured wrong or something because it kept telling me I had a malformed JS file. In reality it was returning HTML inside my JS
The text was updated successfully, but these errors were encountered: