-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: Restructure main navigation #859
Comments
Thank you for your ideas! We will come back to this once we've finished up some other to dos :) |
I've implemented this locally and updated the issue description with some screenshots. I can clean it up and send a PR depending on your feedback |
This might be going in a good direction, but it's too big of a change to just merge and deploy it to everyone... need to think about it, ideally after we had the chance to get some sleep 😉 |
As a quick thought, "media" doesn't seem ideal as the top navigation point... sounds too technical for me, also we should have named our app "MediaPrism" then? 🤔 What about "Search" or "Browse"? I know, browse may be too general, as you can also browse on other pages... |
Yeah, I was not in love with the "Media" name either. I like "Browse" a lot more than "Search". Usually when I'm on that page I'm not using the search box, but just viewing the most recent photos, so the latter doesn't seem quite accurate. I don't think there's an issue with "Browse" being too general. It's called "Photos" today and you can also view "Photos" on other pages, but I've never found that to be an issue I've gone ahead and updated the screenshot and description above to use "Browse" instead |
Not sure if the menu suggestions also covers the functionality of combining photos and videos? If the menu optimisation includes a combined view of photos+videos, I'm all for it - if not, I would like to suggest or create an idea where there is an option to combine the two. |
@nikolajhendel what you want already exists: https://demo.photoprism.org/browse We simply started with Photos, as the name PhotoPrism suggests. So it made sense to put long videos in a separate place. Short videos aka live photos are in Photos. |
We may rework the navigation based on this, but released only 10 days ago. Give us to time to think this over and do it in an orderly fashion. |
Thanks @lastzero for the /browse tip (and not least for an excellent product) - that is exactly the functionality I was after. Just out of curiosity, is the /browse functionality mentioned anywhere (I can't find it in the documentation) - and is there a way to get to it from the menu? (i can get to /photos, /videos, /library, etc. - but there is no menu item that takes me to /browse for the combined view). |
@nikolajhendel you can see more details in #856. It's not that easy to get to yet, but hopefully we can figure out a way to better surface it |
thanks for the link @benmccann, I'll await the (hopeful) change of the main navigation. |
Let us know if this will work for now... |
PS: Had to use "Search" as there is no translation for "Browse". |
@lastzero - absolutely amazing. Thanks so much |
Thanks for the valuable feedback! Thought about changing this earlier - a concern was that users expect the number next to search to be the result count rather than the total number of photos & videos. You may still get to |
Refactoring the remaining navigation will take time, also because we need to wait for translations whenever new words are used. When adding the People page for face recognition, we need to touch it anyway. |
Note hat I've reverted moments / explore back to using the star icon as the "compass" icon looks too much like the video icon (if we change it). |
Preview build is running: https://docs.photoprism.app/getting-started/updates/#development-preview |
I really like the new Shadow theme that's on the demo server. It looks nice! I used Explore as a group heading to put Moments, Calendar, Places, and States under it. It doesn't look like the others have been moved under it though. In my proposal I still had Moments - I think Explore is good for a grouping header, but if we're just going to leave it ungrouped then I think Moments is a clearer name than Explore since it's more indicative of what content is there I'd also suggested other changes like calling it Browse instead of Search and moving Videos under that heading. And also creating a review heading. I'm not sure if these were all decided against since this issue was closed? |
Other suggestions were not explicitly decided against, but that's what we could deliver right now (see my other comments about time and resources). The only thing I would never, never do is hide the maps - one of our most popular features - in the sub-navigation. Also, more changes may need additional translations. I'd rather deliver value to our users now than going for perfection. If you like, you can add a follow-up issue for changes you want to see in a later release! 😃 |
Makes sense that it might not be a priority right now. In the meantime, can we consider renaming Explore back to Moments? I never wanted to get rid of Moments as a header - only group some headers together to reduce the number of items in the menu |
How quick was that? |
Thanks!! 😄 😄 |
While in PhotoPrism the favourite icon is a heart in other apps star is a common icon for that. So maybe I would try not to use star icon for anything else. Have you considered the 'history' or 'supervised_user' or the 'wallpaper' or the 'bubble_chart' or the 'collections' or the 'photo_library' icon for Moments? |
I'd agree with this.
|
I am not against the heart. My proposal is to change the Moments icon to something that's not the star. |
These are highlights based on clusters. So it's like a favorite, unless you didn't enjoy the journey and took lots of pictures to document how bad it was. |
Google BTW also uses Bookmark for albums, just combined in a super ugly photo_album icon featuring a rectangle and a mountain: https://material.io/resources/icons/?search=photo_album&icon=photo_album&style=baseline |
While I admit that the Google icon is super ugly, for some reason I prefer that over the plain bookmark icon :) I was a bit disappointed that you reverted back to bookmark from the ugly icon. :) In regards to the star I understand your logic but still disagree and find the star confusing for average users. But it's your product and it is really a low-value and very minor change so I am happy to let it go. :) |
When we can afford to pay designers, we will get our own super amazing icons. You know what to do: Spread the word! Let's keep the star until we find a better alternative. Charts or bubbles are worse, trust me. Explore would have been good, but not in combination with the new video icon you proposed and got 😉 |
@lastzero - I would say wait for a designer to look at it :) |
Yeah, I don't see how those stars could work in their current format as they don't fit the material design style at all. Maybe this one is close enough? |
I'd like to propose a few ideas for the way the menu is organized. This was spurred by trying to figure out where we might be able to place
/browse
in the menu structure (#856)Before
After
Structure
Description
Some things this accomplishes:
/browse
now has a place in the menu as the main item "Media"Some things I debated:
The text was updated successfully, but these errors were encountered: