Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata: Update and test go-exif #990

Closed
lastzero opened this issue Feb 1, 2021 · 5 comments
Closed

Metadata: Update and test go-exif #990

lastzero opened this issue Feb 1, 2021 · 5 comments
Assignees
Labels
enhancement Optimization, improvement or maintenance task released Available in the stable release

Comments

@lastzero
Copy link
Member

lastzero commented Feb 1, 2021

Support for finding and seeking multiple EXIF blobs has been added, see:

Canon EOS R5 missing metadata #53

@lastzero lastzero added the enhancement Optimization, improvement or maintenance task label Feb 1, 2021
@dsoprea
Copy link
Collaborator

dsoprea commented Feb 2, 2021

It's worth mentioning that this really only benefits unsupported formats. Supported formats tell you exactly where the EXIF blob is. If you're going to use this as a contingency, then just increment the counter and loop until you get an error, and maybe just mash all of the tags together when you're done.

@lastzero
Copy link
Member Author

lastzero commented Feb 5, 2021

@dsoprea Just upgraded. Tests all pass, except one. GoPro camera model is gone:

exif-error

Test file is here: https://github.com/photoprism/photoprism/blob/develop/internal/meta/testdata/gopro_hd2.jpg

Any idea why that is?

@lastzero
Copy link
Member Author

lastzero commented Feb 5, 2021

Model is now missing according to exif-read-tool as well:

$ exif-read-tool -f gopro_hd2.jpg 
IFD-PATH=[IFD] ID=(0x0100) NAME=[ImageWidth] COUNT=(1) TYPE=[SHORT] VALUE=[[3840]]
IFD-PATH=[IFD] ID=(0x0101) NAME=[ImageLength] COUNT=(1) TYPE=[SHORT] VALUE=[[2880]]
IFD-PATH=[IFD] ID=(0x0102) NAME=[BitsPerSample] COUNT=(3) TYPE=[SHORT] VALUE=[[8 8 8]]
IFD-PATH=[IFD] ID=(0x0106) NAME=[PhotometricInterpretation] COUNT=(1) TYPE=[SHORT] VALUE=[[2]]
IFD-PATH=[IFD] ID=(0x010e) NAME=[ImageDescription] COUNT=(14) TYPE=[ASCII] VALUE=[DCIM\100GOPRO]
IFD-PATH=[IFD] ID=(0x010f) NAME=[Make] COUNT=(24) TYPE=[ASCII] VALUE=[GoPro]
IFD-PATH=[IFD] ID=(0x0112) NAME=[Orientation] COUNT=(1) TYPE=[SHORT] VALUE=[[1]]
IFD-PATH=[IFD] ID=(0x0115) NAME=[SamplesPerPixel] COUNT=(1) TYPE=[SHORT] VALUE=[[3]]
IFD-PATH=[IFD] ID=(0x011a) NAME=[XResolution] COUNT=(1) TYPE=[RATIONAL] VALUE=[[720000/10000]]
IFD-PATH=[IFD] ID=(0x011b) NAME=[YResolution] COUNT=(1) TYPE=[RATIONAL] VALUE=[[720000/10000]]
IFD-PATH=[IFD] ID=(0x0128) NAME=[ResolutionUnit] COUNT=(1) TYPE=[SHORT] VALUE=[[2]]
IFD-PATH=[IFD] ID=(0x0131) NAME=[Software] COUNT=(33) TYPE=[ASCII] VALUE=[Adobe Photoshop 21.0 (Macintosh)]
IFD-PATH=[IFD] ID=(0x0132) NAME=[DateTime] COUNT=(20) TYPE=[ASCII] VALUE=[2020:02:19 02:01:04]
IFD-PATH=[IFD] ID=(0x0213) NAME=[YCbCrPositioning] COUNT=(1) TYPE=[SHORT] VALUE=[[1]]
IFD-PATH=[IFD] ID=(0x8769) NAME=[ExifTag] COUNT=(1) TYPE=[LONG] VALUE=[[344]]

@lastzero lastzero self-assigned this Feb 5, 2021
@lastzero lastzero added the in-progress Somebody is working on this label Feb 5, 2021
lastzero added a commit that referenced this issue Feb 5, 2021
@graciousgrey graciousgrey added released Available in the stable release and removed in-progress Somebody is working on this labels Feb 8, 2021
@dsoprea
Copy link
Collaborator

dsoprea commented Feb 8, 2021

Closed, but did we resolve the above?

@lastzero
Copy link
Member Author

lastzero commented Feb 8, 2021

No, unless it can't be fixed? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Optimization, improvement or maintenance task released Available in the stable release
Projects
Status: Released 🌈
Development

No branches or pull requests

3 participants