Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload: Add duplicates to selected albums as well #991

Closed
kardianos opened this issue Feb 1, 2021 · 2 comments
Closed

Upload: Add duplicates to selected albums as well #991

kardianos opened this issue Feb 1, 2021 · 2 comments
Assignees
Labels
enhancement Refactoring, improvement or maintenance task released Available in the stable release

Comments

@kardianos
Copy link

As a user, I would like to add a photo set to an album, even if they are already in the system. Theoretically I could find them within the system and add them, but that can be tricky to find them if there is sufficient entropy.

In internal/photoprism/import_worker.go, we have a few loops and Ifs that import the logic. Of importance here is imp.DestinationFilename and entity.AddPhotoToAlbums. If DestinationFilename fails, no further processing is done. Which is what you normally would want. However, In this case, I would still like to add it to the photos.

Allowing this would require refactoring this function a fair amount and would probably be in two parts: (1) refactor (2) allow adding to album pre-existing photos.

I can make this change and add some unit tests probably, but I would want to get approval for the concept first.

@lastzero lastzero self-assigned this Feb 5, 2021
@lastzero lastzero added the enhancement Refactoring, improvement or maintenance task label Feb 5, 2021
@lastzero lastzero added the please-test Ready for acceptance test label Feb 5, 2021
@lastzero lastzero changed the title Uploaded photo not added to album(s) if already exist Upload: Add duplicates to selected albums as well Feb 5, 2021
lastzero added a commit that referenced this issue Feb 5, 2021
@graciousgrey graciousgrey added released Available in the stable release and removed please-test Ready for acceptance test labels Feb 8, 2021
@lastzero
Copy link
Member

lastzero commented Feb 8, 2021

This has been released. You may test it using our latest Docker image.

@kardianos
Copy link
Author

Works like a charm. Thanks!

@lastzero lastzero moved this to Released 🌈 in Roadmap 🚀✨ Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Refactoring, improvement or maintenance task released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

3 participants