Skip to content

Docker compose has been rolled into the main CLI, so the hyphen is deprecated. - #1192

Closed
ryanpcmcquen wants to merge 1 commit into
photoprism:developfrom
ryanpcmcquen:patch-1
Closed

Docker compose has been rolled into the main CLI, so the hyphen is deprecated.#1192
ryanpcmcquen wants to merge 1 commit into
photoprism:developfrom
ryanpcmcquen:patch-1

Conversation

@ryanpcmcquen

Copy link
Copy Markdown
Docker Compose is now in the Docker CLI, try `docker compose up`

This should probably be propagated to all docker-compose files, but I can only test on Mac, so I only edited this one.

…precated.

```% docker-compose up -d
Docker Compose is now in the Docker CLI, try `docker compose up`
```
@CLAassistant

CLAassistant commented Apr 14, 2021

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@StephenBrown2

Copy link
Copy Markdown
Contributor

Can you specify that this is only for MacOS and Windows? docker-archive/compose-cli#1149 (comment), and for what version of the docker cli this is for? Looks like the message was added to docker-compose 1.28.6, but I'm still running docker-compose version 1.28.5, build c4eb3a1f on my Mac. I can't find mention of compose in the changelog for https://github.com/docker/cli/releases, though the docs mention it is only a tech preview: https://docs.docker.com/compose/cli-command/ and doesn't have full compatibility with docker-compose: https://docs.docker.com/compose/cli-command-compatibility/

❗ Important

The compose command in the Docker CLI is currently available as a Tech Preview. We recommend that you do not use this in production environments.

@alexisLefebvre

Copy link
Copy Markdown
Contributor

I think it's too early, I use Ubuntu 20.04 and the official release channel of Docker and docker compose doesn't work yet:

$ docker compose
docker: 'compose' is not a docker command.
See 'docker --help'
$ docker --version
Docker version 20.10.6, build 370c289

Updating these commands would complicate the usage because users would have to rewrite every docker compose command to docker-compose.

@ryanpcmcquen

Copy link
Copy Markdown
Author

Hahahahaha:

lando/lando#2962

@lastzero

Copy link
Copy Markdown
Member

Let's wait a tiny bit until everyone has the new release. If the info message bothers you, I'm sure there is a way to disable it in the meantime.

@alexisLefebvre

Copy link
Copy Markdown
Contributor

Users should be able to use an alias in their shell from docker-compose to docker compose in order to use any version without seeing the message about the deprecation.

@lastzero lastzero self-assigned this Apr 19, 2021
@lastzero lastzero added the needs-work Has problems that need to be resolved label Apr 19, 2021
@alexisLefebvre

alexisLefebvre commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

I stumbled upon this PR again, and I saw that it targets only the documentation for MacOS. If the last release of Docker on MacOS deprecate docker-compose, then this PR can be merged.

@StephenBrown2

Copy link
Copy Markdown
Contributor

Docker Compose 2.0 is still in beta, and breaks at least one docker-compose.yml file (the main one used for local dev at my work), so I would recommend not switching any documentation, and perhaps adding docker-compose disable-v2 to the docs instead until it's verified that 2.0 works with this compose file.

@lastzero

Copy link
Copy Markdown
Member

@alexisLefebvre According to my tests, the "docker compose ..." subcommands are only optional if you explicitly install the "docker-compose-plugin". It may be that some distributions and Docker Desktop do this, but in general it does not seem to be the default.

lastzero added a commit that referenced this pull request Nov 5, 2022
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this pull request Nov 5, 2022
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit to photoprism/photoprism-docs that referenced this pull request Nov 5, 2022
@lastzero lastzero added released Available in a stable release docs 📚 Improvements or additions to documentation please-test Ready for manual testing & feedback and removed needs-work Has problems that need to be resolved released Available in a stable release labels Nov 5, 2022
lastzero added a commit that referenced this pull request Nov 5, 2022
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero

lastzero commented Nov 5, 2022

Copy link
Copy Markdown
Member

I have changed this everywhere I found it. You are welcome to help me check if all changes are correct!

lastzero added a commit to photoprism/photoprism-docs that referenced this pull request Nov 5, 2022
@lastzero lastzero closed this Nov 5, 2022
lastzero added a commit to photoprism/photoprism-docs that referenced this pull request Nov 5, 2022
lastzero added a commit to photoprism/photoprism-docs that referenced this pull request Nov 5, 2022
chain710 pushed a commit to chain710/photoprism that referenced this pull request Nov 7, 2022
* merge-221105: (346 commits)
  UX: Improve layout of form fields in photo edit dialog
  Account: Disable "gender" dropdown when busy photoprism#98
  Docker: Change "docker-compose" command to "docker compose" photoprism#1192
  Docker: Use docker compose profiles for watchtower example photoprism#1192
  Docker: Change "docker-compose" command to "docker compose" photoprism#1192
  Frontend: Upgrade dependencies in package.json and package-lock.json
  Frontend: Update translations.json and package-lock.json
  Weblate: Update backend translations
  Weblate: Update frontend translations
  Weblate: Update frontend translations
  Develop: Add "FOR TEST AND DEVELOPMENT ONLY" warning to config files
  NVIDIA: Update docker-compose.yml example photoprism#2613
  NVIDIA: Add docker-compose.yml example photoprism#2613
  NVIDIA: Update install-gpu.sh script photoprism#2613
  Frontend: Update translations.json and package-lock.json
  Weblate: Update frontend translations
  Tests: Refactor acceptance tests
  Tests: Add DateTime unit test
  Video: Change FFmpeg params for NVidia hardware transcoding photoprism#2613
  Frontend: Update package-lock.json
  ...
@lastzero lastzero added released Available in a stable release and removed please-test Ready for manual testing & feedback labels Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs 📚 Improvements or additions to documentation released Available in a stable release

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants