New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend: RTL alignment fixes #1220
Conversation
haimkastner
commented
Apr 23, 2021
- Navigation sub-menu item margin
- Notifier RTL text support
- Media list view headers direction
- Edit photo details view
- Share content view
- Upload media RTL text support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a couple !rtl
s got copy-pasted...
@@ -10,7 +10,7 @@ | |||
<translate key="Upload">Upload</translate> | |||
</v-toolbar-title> | |||
</v-toolbar> | |||
<v-container grid-list-xs text-xs-left fluid> | |||
<v-container grid-list-xs :text-xs-left="!rtl" :text-xs-right="!rtl" fluid> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<v-container grid-list-xs :text-xs-left="!rtl" :text-xs-right="!rtl" fluid> | |
<v-container grid-list-xs :text-xs-left="!rtl" :text-xs-right="rtl" fluid> |
@@ -100,7 +100,7 @@ | |||
</v-expansion-panel-content> | |||
</v-expansion-panel> | |||
|
|||
<v-container fluid text-xs-left class="pb-0 pt-3 pr-0 pl-0 caption"> | |||
<v-container fluid :text-xs-left="!rtl" :text-xs-right="!rtl" class="pb-0 pt-3 pr-0 pl-0 caption"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this got copy-pasted...
<v-container fluid :text-xs-left="!rtl" :text-xs-right="!rtl" class="pb-0 pt-3 pr-0 pl-0 caption"> | |
<v-container fluid :text-xs-left="!rtl" :text-xs-right="rtl" class="pb-0 pt-3 pr-0 pl-0 caption"> |
Hi @StephenBrown2, Yes, you're right about the "copy-paste". Most of the "vuetifyjs" components support RTL out-of-the-box. But some of the styles are not supported RTL natively the and I didn't found a better way to implement it other than a high-risk CSS styles override. Do you know a better way to do that? By the way, I already set the first RTL supported using this ugly way see #801 |
Ah, good to know. I'm not familiar with RTL or really Vuetify yet, so your guess is as good as mine. |
Is this good to merge? |
Any update on this? |
Hi @graciousgrey, |