Albums: Preload more items for auto-completion in "Add to album" dialog#2152
Merged
lastzero merged 1 commit intophotoprism:developfrom Mar 23, 2022
Merged
Albums: Preload more items for auto-completion in "Add to album" dialog#2152lastzero merged 1 commit intophotoprism:developfrom
lastzero merged 1 commit intophotoprism:developfrom
Conversation
Member
|
Thanks! Apparently we didn't expect private users to have more than 1000 albums when implementing this... |
lastzero
added a commit
that referenced
this pull request
Mar 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small hotfix to the "Add photos to album" dialog.
If there are more than 1000 albums in photoprism, a problem arises in the user interface:
This pull requests increases the max album fetch
countto 10000 as quickfix and removes the magic number, declaringMAX_COUNTas explicit constant.Future improvements of REST API may one of the following:
countquery parameter optionalBackground:
I have a bunch of auto-generated albums (> 1000) from external sources and found it very confusing, that only one half of albums have been displayed in the autocomplete.
Acceptance Criteria:
This is a small change (projects with < 1000 albums not affected in any way), hence following points are neglected: