Metadata: When parsing dates from exiftool, remap year 0 to 1 - #2508
Merged
Conversation
Member
|
@carlonluca My apologies for the long delay! This looks good to me. Would you be able to resolve the conflicts so we can merge your changes automatically? If not, let me know so I can add the changes manually. Thank you very much! ❤️ |
Year 0 is frequently used in exiftool but is not accepted in the Go time package. time package uses year 1 for "zero" dates instead. Therefore, remap year 0 from exiftool to year 1.
carlonluca
force-pushed
the
fix-null-date
branch
from
June 28, 2023 19:48
bd65af6 to
ae06d78
Compare
Member
|
Thank you! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Year 0 is frequently used in exiftool but is not accepted in the Go time
package. time package uses year 1 for "zero" dates instead. Therefore,
remap year 0 from exiftool to year 1.
Acceptance Criteria: