Skip to content

Metadata: When parsing dates from exiftool, remap year 0 to 1 - #2508

Merged
lastzero merged 1 commit into
photoprism:developfrom
carlonluca:fix-null-date
Jun 29, 2023
Merged

Metadata: When parsing dates from exiftool, remap year 0 to 1#2508
lastzero merged 1 commit into
photoprism:developfrom
carlonluca:fix-null-date

Conversation

@carlonluca

@carlonluca carlonluca commented Jul 9, 2022

Copy link
Copy Markdown
Contributor

Year 0 is frequently used in exiftool but is not accepted in the Go time
package. time package uses year 1 for "zero" dates instead. Therefore,
remap year 0 from exiftool to year 1.

Acceptance Criteria:

  • Features and improvements are fully implemented so that they can be released at any time without additional work
  • Automated unit and/or acceptance tests have been added to ensure the changes work as expected and to reduce repetitive manual work
  • Contributor License Agreement (CLA) has been signed

@CLAassistant

CLAassistant commented Jul 9, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@lastzero

Copy link
Copy Markdown
Member

@carlonluca My apologies for the long delay! This looks good to me. Would you be able to resolve the conflicts so we can merge your changes automatically? If not, let me know so I can add the changes manually. Thank you very much! ❤️

@lastzero lastzero added needs-work Has problems that need to be resolved enhancement metadata Related to Exif, XMP, IPTC & Co. labels Jun 27, 2023
@lastzero lastzero changed the title When parsing dates from exiftool, remap year 0 to 1 Metadata: When parsing dates from exiftool, remap year 0 to 1 Jun 27, 2023
Year 0 is frequently used in exiftool but is not accepted in the Go time
package. time package uses year 1 for "zero" dates instead. Therefore,
remap year 0 from exiftool to year 1.
@lastzero

Copy link
Copy Markdown
Member

Thank you! ❤️

@lastzero
lastzero merged commit 9a699f2 into photoprism:develop Jun 29, 2023
@lastzero lastzero added please-test Ready for manual testing & feedback merged Changes are merged, but may require further testing and removed needs-work Has problems that need to be resolved work-in-progress labels Jun 29, 2023
@lastzero lastzero added released Available in a stable release and removed please-test Ready for manual testing & feedback merged Changes are merged, but may require further testing labels Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metadata Related to Exif, XMP, IPTC & Co. released Available in a stable release

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants