-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Config: Improve inline docs in docker-compose.yml examples #2536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edited a few comments for clarity. The primary reason for this edit is the "# Raspberry V4L2 (camera driver)" change. I initially (naively) thought this entry was required in order to use hardware acceleration on the Raspberry Pi.
|
lastzero
added a commit
that referenced
this pull request
Jul 22, 2022
Signed-off-by: Michael Mayer <michael@photoprism.app>
Will these changes work for you? |
lastzero
added a commit
that referenced
this pull request
Jul 29, 2022
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero
added a commit
that referenced
this pull request
Jul 29, 2022
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero
added a commit
that referenced
this pull request
Jul 29, 2022
Signed-off-by: Michael Mayer <michael@photoprism.app>
These changes look good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first-ever pull request. If I've done this right, I'll contribute more substantially later.
In this commit, I edited a few comments for clarity. Should such edits be made individually to each architecture's docker-compose.yml, or is there a root file which propagates to the different architectures?
The primary reason for this edit in particular was the "# Raspberry V4L2" line. I initially (naively) thought this entry referred to hardware acceleration on the Raspberry Pi; I added "(camera driver)" to make it clear.
Acceptance Criteria: