Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import: Index original filenames of related files #2623

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

natiz
Copy link
Contributor

@natiz natiz commented Aug 20, 2022

When uploading multiple related/stackable files, the non-primary files are missing the Original Name attribute. This PR ensures they are also assigned with their original file name.

Acceptance Criteria:

  • Features and improvements are fully implemented so that they can be released at any time without additional work
  • Automated unit and/or acceptance tests have been added to ensure the changes work as expected and to reduce repetitive manual work
  • User interface changes are fully responsive and have been tested on all major browsers and various devices
  • Database-related changes are compatible with SQLite and MariaDB
  • Translations have been / will be updated (specify if needed)
  • Documentation has been / will be updated (specify if needed)
  • Contributor License Agreement (CLA) has been signed

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2022

CLA assistant check
All committers have signed the CLA.

@graciousgrey
Copy link
Member

Thank you for your contribution!

Because we want to create the best possible product for our users, we have a set of guidelines which ensure that all source code contributions are acceptable:

  • The feature must be fully implemented
  • Unit and acceptance tests have to be written
  • The feature must work with sqlite and mysql
  • The UI must be fully responsive
  • It needs to be tested on multiple browsers and devices
  • Translations need to be created for all languages
  • Docs need to be updated

Reviewing, testing and finally merging pull requests consumes significant resources on our side. Unless it's just a small fix, it may take several months.

Thanks for your patience :)

@lastzero
Copy link
Member

I will merge this improvement so it can be tested in our preview build. Thank you very much! 🥳

@lastzero lastzero changed the title Fix: Original file name of related files Import: Save the original filenames of related files Sep 15, 2022
@lastzero lastzero added the enhancement Refactoring, improvement or maintenance task label Sep 15, 2022
@lastzero lastzero merged commit 9056707 into photoprism:develop Sep 15, 2022
@lastzero lastzero changed the title Import: Save the original filenames of related files Import: Index original filenames of related files Sep 15, 2022
lastzero added a commit that referenced this pull request Sep 15, 2022
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero added the please-test Ready for acceptance test label Sep 15, 2022
@lastzero
Copy link
Member

I have started a new preview build for testing which should be available soon.

@lastzero lastzero added released Available in the stable release and removed please-test Ready for acceptance test labels Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Refactoring, improvement or maintenance task released Available in the stable release
Projects
Status: Release 🌈
Development

Successfully merging this pull request may close these issues.

4 participants