Skip to content

HEIF: Add Sony .HIF file extension#2693

Merged
lastzero merged 1 commit intophotoprism:developfrom
dynm:patch-1
Sep 14, 2022
Merged

HEIF: Add Sony .HIF file extension#2693
lastzero merged 1 commit intophotoprism:developfrom
dynm:patch-1

Conversation

@dynm
Copy link
Copy Markdown
Contributor

@dynm dynm commented Sep 10, 2022

Add file extension ".HIF" for Sony HEIF images.
Currently, change ".HIF" to ".HEIF" can import into PhotoPrism without problems for 4:2:2 10bit images.

Acceptance Criteria:

  • Features and enhancements are fully implemented so that they can be released at any time without additional work
  • Automated unit and/or acceptance tests have been added to ensure the changes work as expected and to reduce repetitive manual work
  • User interface changes are fully responsive and have been tested on all major browsers and various devices
  • Database-related changes are compatible with SQLite and MariaDB
  • Translations have been / will be updated (specify if needed)
  • Documentation has been / will be updated (specify if needed)
  • Contributor License Agreement (CLA) has been signed

Sony HEIF uses the ".HIF" file extension.
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 10, 2022

CLA assistant check
All committers have signed the CLA.

@lastzero
Copy link
Copy Markdown
Member

Awesome, thank you! Going to merge it next week when we're back in Berlin 👍

Do you know (or can you test) if the Sony HEIF format is compatible with other converters such as Darktable, Rawtherapee, Sips, or ImageMagick? Assuming your PR uses the default heif-convert command.

@dynm
Copy link
Copy Markdown
Contributor Author

dynm commented Sep 10, 2022

Awesome, thank you! Going to merge it next week when we're back in Berlin 👍

Do you know (or can you test) if the Sony HEIF format is compatible with other converters such as Darktable, Rawtherapee, Sips, or ImageMagick? Assuming your PR uses the default heif-convert command.

Ok, I'll test all of these programs ASAP.😄

@dynm
Copy link
Copy Markdown
Contributor Author

dynm commented Sep 10, 2022

According to my test:

  • Darktable will crop and make image into landscape by padding right
  • Rawtherapee cannot load the image folder
  • Sips sips -s format jpeg origin.HIF --out output-sips.jpg produces almost same brightness like macOS Preview app
  • ImageMagick magick origin.HIF output-magick.jpg produces brighter jpeg than sips

image

@lastzero
Copy link
Copy Markdown
Member

So the JPEG created by heif-convert is "best"?

@dynm
Copy link
Copy Markdown
Contributor Author

dynm commented Sep 11, 2022

JPEG created by heif-convert is a little brighter than origin and looks like magick's output, looks good to me.

@lastzero lastzero added the raw RAW File Format Support label Sep 14, 2022
@lastzero lastzero merged commit 1673bb0 into photoprism:develop Sep 14, 2022
@lastzero lastzero changed the title Add Sony .HIF file extension HEIF: Add Sony .HIF file extension Sep 14, 2022
@lastzero lastzero added please-test Ready for acceptance test enhancement Enhancement or improvement of an existing feature labels Sep 14, 2022
@lastzero lastzero added released Available in the stable release and removed please-test Ready for acceptance test labels Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement of an existing feature raw RAW File Format Support released Available in the stable release

Projects

Status: Release 🌈

Development

Successfully merging this pull request may close these issues.

3 participants