Skip to content

Few RTL alignment fixes#2732

Merged
lastzero merged 1 commit into
photoprism:developfrom
haimkastner:fixes/rtl-alignment-fixes
Sep 24, 2022
Merged

Few RTL alignment fixes#2732
lastzero merged 1 commit into
photoprism:developfrom
haimkastner:fixes/rtl-alignment-fixes

Conversation

@haimkastner

@haimkastner haimkastner commented Sep 23, 2022

Copy link
Copy Markdown
Contributor
  • Fix list view headers alignment
  • Fix upload dialog text direction
  • Add missing alignment style to the new faces toolbar icons

Acceptance Criteria:

  • Features and enhancements are fully implemented so that they can be released at any time without additional work
  • Automated unit and/or acceptance tests have been added to ensure the changes work as expected and to reduce repetitive manual work
  • User interface changes are fully responsive and have been tested on all major browsers and various devices
  • Database-related changes are compatible with SQLite and MariaDB
  • Translations have been / will be updated (specify if needed)
  • Documentation has been / will be updated (specify if needed)
  • Contributor License Agreement (CLA) has been signed

- Fix list view headers alignment
- Fix upload dialog text direction
- Add missing alignment style to the new faces toolbar icons
@CLAassistant

CLAassistant commented Sep 23, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@haimkastner

Copy link
Copy Markdown
Contributor Author

Fix list view headers alignment
image

Fix upload dialog text direction
image

Add missing alignment style to the new faces toolbar icons
image

@lastzero

Copy link
Copy Markdown
Member

Excellent, thank you very much! Adding class="page-toolbar" to faces.vue was a cosmetic change, I assume, or does it also affect the RTL rendering?

@lastzero lastzero self-assigned this Sep 24, 2022
@lastzero lastzero merged commit db80cb2 into photoprism:develop Sep 24, 2022
@haimkastner

Copy link
Copy Markdown
Contributor Author

Hi @lastzero
Thank you too for this great project :)

The missing page-toolbar affects a few alignment styles, including the left margin, in the LTR view it's almost not visible, but in the RTL view is significantly noticed.

@lastzero lastzero added ux Impacts User Experience frontend Requires experience with HTML/JS/CSS bug merged Changes are merged, but may require further testing labels Sep 28, 2022
@haimkastner haimkastner deleted the fixes/rtl-alignment-fixes branch September 28, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Requires experience with HTML/JS/CSS merged Changes are merged, but may require further testing ux Impacts User Experience

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants