-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Moments: Add holidays and additional pets #3081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Add large Holidays * Add assortment of pets
Thank you very much, we appreciate your efforts! The idea of the moments is that they should be completely automated. I've never seen the labels (especially the ones for the holidays) come from Tensorflow or reverse geocoding. Did you manually add these to your files or where did they come from? For holiday moments, we probably need some settings or localization as well, since not everyone celebrates Christmas or Thanksgiving. |
The Holiday ones are added manually to the files, I was still hoping there would be some kind of option to be able to manually add them since they are being read from the labels that are given to the photos. My initial idea for that would be a section where we would be able to add Moments ourselves instead of hard coding them in the source code. |
What you want to achieve sounds more like: |
We can add "parakeet" and "gerbil" to Pets. A turtle is usually a wild animal (so probably in most of the pictures people have), although I know for sure that there are a few turtle lovers who have them at home (in which case this is not true, but then again, some people have a cheetah at home). What a holiday is also depends on the culture and the region. So before we can add that, there must be a way to customize it. There are big differences between holidays e.g. in Israel, the USA and Europe, and probably Asia as well, although I am not an expert on this. |
@fly-man- I will merge this and then test & refactor it as needed so we can release it. You might be right that the additional holiday moment can be added safely, since it requires that the labels exist in the first place. Thank you! |
Signed-off-by: Michael Mayer <michael@photoprism.app>
You can now help test this with our preview build and on our public demo. An overview of all changes can be found in the Release Notes at docs.photoprism.app/release-notes/#development-preview. |
Acceptance Criteria: