Skip to content

Moments: Add holidays and additional pets #3081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

fly-man-
Copy link
Contributor

@fly-man- fly-man- commented Jan 9, 2023

  • Add large Holidays
  • Add assortment of pets

Acceptance Criteria:

  • Features and enhancements are fully implemented so that they can be released at any time without additional work
  • Automated unit and/or acceptance tests have been added to ensure the changes work as expected and to reduce repetitive manual work
  • User interface changes are fully responsive and have been tested on all major browsers and various devices
  • Database-related changes are compatible with SQLite and MariaDB
  • Translations have been / will be updated (specify if needed)
  • Documentation has been / will be updated (specify if needed)
  • Contributor License Agreement (CLA) has been signed

* Add large Holidays
* Add assortment of pets
@CLAassistant
Copy link

CLAassistant commented Jan 9, 2023

CLA assistant check
All committers have signed the CLA.

@graciousgrey
Copy link
Member

graciousgrey commented Jan 11, 2023

Thank you very much, we appreciate your efforts!

The idea of the moments is that they should be completely automated. I've never seen the labels (especially the ones for the holidays) come from Tensorflow or reverse geocoding. Did you manually add these to your files or where did they come from?

For holiday moments, we probably need some settings or localization as well, since not everyone celebrates Christmas or Thanksgiving.

@fly-man-
Copy link
Contributor Author

The Holiday ones are added manually to the files, I was still hoping there would be some kind of option to be able to manually add them since they are being read from the labels that are given to the photos.

My initial idea for that would be a section where we would be able to add Moments ourselves instead of hard coding them in the source code.

@graciousgrey
Copy link
Member

What you want to achieve sounds more like:

@lastzero
Copy link
Member

We can add "parakeet" and "gerbil" to Pets. A turtle is usually a wild animal (so probably in most of the pictures people have), although I know for sure that there are a few turtle lovers who have them at home (in which case this is not true, but then again, some people have a cheetah at home).

What a holiday is also depends on the culture and the region. So before we can add that, there must be a way to customize it. There are big differences between holidays e.g. in Israel, the USA and Europe, and probably Asia as well, although I am not an expert on this.

@lastzero
Copy link
Member

@fly-man- I will merge this and then test & refactor it as needed so we can release it. You might be right that the additional holiday moment can be added safely, since it requires that the labels exist in the first place. Thank you!

@lastzero lastzero merged commit 4ecece5 into photoprism:develop Jun 13, 2023
@lastzero lastzero added enhancement Enhancement or improvement of an existing feature merged Changes are merged, but may require further testing labels Jun 13, 2023
@lastzero lastzero changed the title Update MomentLabels Moments: Add holidays and additional pets Jun 13, 2023
lastzero added a commit that referenced this pull request Jun 13, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero added the please-test Ready for acceptance test label Jun 13, 2023
@lastzero
Copy link
Member

You can now help test this with our preview build and on our public demo. An overview of all changes can be found in the Release Notes at docs.photoprism.app/release-notes/#development-preview.

@lastzero lastzero added released Available in the stable release and removed please-test Ready for acceptance test labels Jun 15, 2023
@fly-man- fly-man- deleted the patch-1 branch June 16, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement of an existing feature merged Changes are merged, but may require further testing released Available in the stable release
Projects
Status: Release 🌈
Development

Successfully merging this pull request may close these issues.

4 participants