Skip to content

Photos: Show albums in the Info tab of the edit dialog #3095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 13, 2023

Conversation

mmaravillo
Copy link

@mmaravillo mmaravillo commented Jan 12, 2023

Route "GET /api/v1/photos/:uid" chain of calls to the following GetPhoto -> PhotoPreloadByUID -> PreloadMany -> PreloadAlbums does eventually query the database table photos_albums but the Album array in Photos does not get populated.

PR includes sample to display which albums a photo belongs to in the Info dialog.

image

Acceptance Criteria:

  • Features and enhancements are fully implemented so that they can be released at any time without additional work
  • Automated unit and/or acceptance tests have been added to ensure the changes work as expected and to reduce repetitive manual work
  • User interface changes are fully responsive and have been tested on all major browsers and various devices
  • Database-related changes are compatible with SQLite and MariaDB
  • Translations have been / will be updated (specify if needed)
  • Documentation has been / will be updated (specify if needed)
  • Contributor License Agreement (CLA) has been signed

@CLAassistant
Copy link

CLAassistant commented Jan 12, 2023

CLA assistant check
All committers have signed the CLA.

@lastzero
Copy link
Member

Thank you! If this works, that would be a quick win. I will merge this and then try to figure out why albums were excluded from the JSON response. The related commit looks like it should have only been excluded from the YAML backups, which is correct.

@lastzero lastzero added the enhancement Enhancement or improvement of an existing feature label Jun 13, 2023
@lastzero lastzero self-assigned this Jun 13, 2023
@lastzero lastzero merged commit 0b9cb2e into photoprism:develop Jun 13, 2023
@lastzero lastzero changed the title Fix to get Albums array populated Metadata: Show albums in the Info tab of the edit dialog Jun 13, 2023
@lastzero lastzero changed the title Metadata: Show albums in the Info tab of the edit dialog UX: Show albums in the Info tab of the edit dialog Jun 13, 2023
@lastzero lastzero added ux Impacts User Experience please-test Ready for acceptance test merged Changes are merged, but may require further testing labels Jun 13, 2023
lastzero added a commit that referenced this pull request Jun 13, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero
Copy link
Member

A new development preview will be available for testing soon! 👍

@lastzero lastzero changed the title UX: Show albums in the Info tab of the edit dialog Photos: Show albums in the Info tab of the edit dialog Jun 13, 2023
@lastzero
Copy link
Member

lastzero commented Jun 13, 2023

You can now help test this with our preview build and on our public demo. An overview of all changes can be found in the Release Notes at docs.photoprism.app/release-notes/#development-preview.

lastzero added a commit that referenced this pull request Jun 15, 2023
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero
Copy link
Member

I had to update the query to hide albums from which a photo has been removed. So much for the "quick win"! 😆

@lastzero lastzero added released Available in the stable release and removed please-test Ready for acceptance test labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement of an existing feature merged Changes are merged, but may require further testing released Available in the stable release ux Impacts User Experience
Projects
Status: Release 🌈
Development

Successfully merging this pull request may close these issues.

4 participants