-
-
Notifications
You must be signed in to change notification settings - Fork 2k
UX: Add preview image to the labels tab in the photo edit dialog #3532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: Add preview image to the labels tab in the photo edit dialog #3532
Conversation
Thanks! We'll provide more feedback when we are back in our office. |
a03cf90
to
b98ce5d
Compare
@reubendowle I'll merge this, but need to refactor it as photoprism/frontend/src/app.js Lines 64 to 66 in 84a4c3c
|
Ideally we can also add a thumbnail to the ⚙️ tab. |
@graciousgrey I'll check if that's possible. It might be good to add a component for this so we don't have to copy and paste the code into each tab.... |
Signed-off-by: Michael Mayer <michael@photoprism.app>
Updated our release notes and the preview build, so you can test this: |
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero personally this looks fine for me at most sizes of the browser window on PC. I guess when the width gets too narrow triggers a scrollbar: But this is the same behavior as the details tab. So maybe it can just be left like that, and maybe remove the isMobile condition completely? |
I've already merged and refactored it yesterday. It's now deployed on our demo and available with our preview build. |
Useful feature, but (for me) the most useful would be to have it on "people" tab... |
@loulou91 Instead of rendering the image on each tab and thus reducing the space available for the actual content, I was thinking about a statically positioned preview e.g. in the lower left corner. However, we just merged a lot of PR and are still busy making them releasable, so this will have to wait a bit. |
This pull requests adds an image preview when editing labels.
This is to address this issue: #628
The issue points out that there is limited space for thumbnails on mobile devices, so it will be hidden on mobile devices.
Acceptance Criteria: