-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Search: Add altitude range filter #3800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search: Add altitude range filter #3800
Conversation
I have added a docs commit on my fork of photoprism-docs repository, however i'm not sure how to proceed. Should I create a PR for that if this PR was merged? photoprism/photoprism-docs@master...Gilbert32:photoprism-docs:feature/filter_altitude |
Thank you! I think it makes sense to implement this in a similar way as I've just added this: |
Awesome! I will adjust my code as soon as I have free time. Until then, I'm marking the issue as not fully implemented. |
9c3ccb9
to
e8a491e
Compare
I've updated the PR, now the code uses IntRange instead of separate min and max filters. |
@Gilbert32 I'll merge this now, but may need to change a few details:
Thank you for your contribution! 🥇 |
Signed-off-by: Michael Mayer <michael@photoprism.app>
This pull request adds 2 search parameters, maxalt (Maximum Altitude inclusive) and minalt (Minimum Altitude inclusive).
It uses the column photos.photo_altitude to filter photos based on the specified query.
I have added the 2 parameters and basic tests based on my need, however given I don't have extensive knowledge in the photoprism source code, and go, There's the possibility I might have missed to implement it in some place in the source code.
I also added basic tests and they passed.
Acceptance Criteria: