Import: Add option to not delete empty folders#4092
Closed
zhzy0077 wants to merge 1 commit into
Closed
Conversation
Member
|
Thank you very much for your contribution. We will review it as soon as our time allows. |
lastzero
added a commit
that referenced
this pull request
Mar 28, 2025
This prevents directories from being deleted when using the "move" import option, which would otherwise delete hidden files and empty directories. Signed-off-by: Michael Mayer <michael@photoprism.app>
Member
|
@zhzy0077 Thanks again for your contribution and feedback! We're sorry we couldn't get to this sooner. π The above commit will preserve any ".keep" and/or ".gitkeep" files in import directories. So if you add one, this will prevent the folder from being deleted, since only empty directories are deleted when using the move option. Does this meet your needs? Any help in testing this with our preview build will be much appreciated:
Since this is now implemented and the changes in the PR are no longer needed, I will close it and set the status to Preview for final testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Synology Cloud Sync, it fails to sync to the WebDav when the folder doesn't exist. It won't create folders as part of the incremental sync. As a result, people see
The changes in this PR allow user to set a configuration to stop deleting empty folders after import.
No.
Acceptance Criteria: