UX: Update counters and covers in the background#4323
Closed
tschechniker wants to merge 1 commit intophotoprism:developfrom
Closed
UX: Update counters and covers in the background#4323tschechniker wants to merge 1 commit intophotoprism:developfrom
tschechniker wants to merge 1 commit intophotoprism:developfrom
Conversation
Member
|
@tschechniker Thank you so much! I apologize for not getting back to you sooner. Unfortunately, I've only just noticed this great suggestion. However, while it seems like a generally good idea to update counters and covers in the background, it might affect the frontend in unexpected ways - so I'd rather not merge this without having time to properly test it. We'll make sure it doesn't get forgotten (again)! |
lastzero
added a commit
that referenced
this pull request
Mar 28, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
Member
|
@tschechniker Thanks again for your contribution! Based on your proof-of-concept, the above commit updates counters and covers in the background where possible. I will therefore go ahead and close this PR as it is no longer needed. I'm very sorry we couldn't get this released sooner. π |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a library of about 150K of photos. Even with an optimized MariaDB every Approve/Archive Batch action takes about 4 seconds. I debugged and found that from these 4 seconds 3.5 seconds are used to regenerate counters. This can easily be done in the background.
Now if i move a photo to the archive it takes milliseconds again π
Acceptance Criteria: