FFmpeg: Fix Intel Quick Sync Video (QSV) hardware transcoding#4382
FFmpeg: Fix Intel Quick Sync Video (QSV) hardware transcoding#4382hicasper wants to merge 1 commit into
Conversation
|
@hicasper Thanks a lot for submitting this fix! I'm very sorry that I only noticed it now. I'll test and apply your changes once I have a test environment set up to verify that they (still) work with the current release. π¬ |
Signed-off-by: Michael Mayer <michael@photoprism.app>
|
I've just verified that it works. However, I was only able to transcode videos on my Linux Mint host (and not in our Docker development environment), which still has ffmpeg 6.1.1 installed (the version of ffmpeg 7.0.2 I have does not support hardware transcoding). The above commit therefore changes the ffmpeg command flags for Intel QSV as suggested, and also adds hardware transcoding tests for Intel and Nvidia. Note that the FFmpeg docs should also be updated, as the problematic command flag is still mentioned there: |
|
Since the changes were applied manually due to conflicts, I'm going to close this PR (instead of merging it) and then set the status to preview. Thanks again! This was very helpful. |
When using ffmpeg 7 and intel_qsv to transcode videos, it will shows
So I remove
qsv_devicearg, as #1337 (comment) mentioned, let ffmpeg to decide which device to use, it works well on both ffmpeg 6 and 7Acceptance Criteria: