CI: Add codespell config and fix typos#4506
Conversation
|
|
yarikoptic
force-pushed
the
enh-codespell
branch
from
854cd25 to
b9f652d
Compare
|
is there a way to trigger some testing? otherwise -- this is an easy to review PR, don't get scared by number of files, quite often it is just one typo fix per file. |
|
@yarikoptic I apologize for not getting back to you any sooner! The reason we've been so reluctant with this is because of security concerns regarding GitHub Actions (especially when adding/modifying them through pull requests). See, for example: That being said, we'd be happy to merge the spelling fixes without the action configuration and/or add an additional Make target that runs a spell check locally, just like eslint. It would be worth looking at https://github.com/golangci/golangci-lint for this as well, since Would that be possible? I'll be happy to help with this and answer any questions :) |
lastzero
added
waiting
lastzero
changed the title
|
sure -- concerns are well understood I must say especially if you have/use some secrets (I might have missed but I do not think you do yet). Anything is fine with me. I can easily redo and drop CI action. Just let me know if you would have time now to review so we do not breed conflicts and require re-doing? |
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w -i 3 -C 2",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
+ fixed few manually and melded here in frontend/src/css/vendor/icons/material-design-icons.css which was ignored
Conflicts upon rebased -- files were removed in develop:
frontend/src/css/vendor/icons/fonts/MaterialIcons-Regular.json
frontend/src/css/vendor/icons/material-design-icons.css
…agically
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
yarikoptic
force-pushed
the
enh-codespell
branch
from
b9f652d to
540ed37
Compare
|
actually, "easier done than said" so here is an updated -- dropped CI, rebased, added a few ignore pragmas, less changes to review |
|
Excellent, thank you very much! I'll go ahead and merge this. |
lastzero
changed the title
lastzero
changed the title
Signed-off-by: Michael Mayer <michael@photoprism.app>
|
@yarikoptic This is now included in our preview build! Note that I had to fix some minor issues, for example using |
|
Oh, so sorry that my Python rotten mind saw everything as Python code. Yes, it should work with a proper to the language comment |
4 participants
More about codespell: https://github.com/codespell-project/codespell .
I personally introduced it to dozens if not hundreds of projects already and so far only positive feedback.
CI workflow has 'permissions' set only to 'read' so also should be safe.