Videos: Add log-statement to convert_video_avc.go - #4549
Closed
Akashic101 wants to merge 1 commit into
Closed
Conversation
Just a small change, this prints out that no conversion is needed when a video already had been previously converted. Currently running `docker compose exec photoprism photoprism convert` is a very quiet command with basically no output if already run at a previous point, leaving me unsure how much progress has been achieved. This small log fixes that by providing a quick log about where the converter is right now
Member
|
@Akashic101 My apologies for not getting back to you any sooner! We should be able to merge this if you change the log message as follows: |
lastzero
added a commit
that referenced
this pull request
Mar 27, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
Member
|
@Akashic101 I'm happy to report that your proposal has been implemented as part of the above commit. I will therefore close this PR as it is no longer needed. Thank you for your contribution! π |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small change, this prints out that no conversion is needed when a video already had been previously converted. Currently running
docker compose exec photoprism photoprism convertis a very quiet command with basically no output if already run at a previous point, leaving me unsure how much progress has been achieved. This small log fixes that by providing a quick log about where the converter is right nowAcceptance Criteria: