Skip to content

Videos: Add log-statement to convert_video_avc.go - #4549

Closed
Akashic101 wants to merge 1 commit into
photoprism:developfrom
Akashic101:patch-1
Closed

Videos: Add log-statement to convert_video_avc.go#4549
Akashic101 wants to merge 1 commit into
photoprism:developfrom
Akashic101:patch-1

Conversation

@Akashic101

@Akashic101 Akashic101 commented Sep 24, 2024

Copy link
Copy Markdown

Just a small change, this prints out that no conversion is needed when a video already had been previously converted. Currently running docker compose exec photoprism photoprism convert is a very quiet command with basically no output if already run at a previous point, leaving me unsure how much progress has been achieved. This small log fixes that by providing a quick log about where the converter is right now

Acceptance Criteria:

  • Features and enhancements must be fully implemented so that they can be released at any time without additional work
  • Automated unit and/or acceptance tests are mandatory to ensure the changes work as expected and to reduce repetitive manual work
  • Frontend components must be responsive to work and look properly on phones, tablets, and desktop computers; you must have tested them on all major browsers and different devices
  • Documentation and translation updates should be provided if needed
  • In case you submit database-related changes, they must be tested and compatible with SQLite 3 and MariaDB 10.5.12+

Just a small change, this prints out that no conversion is needed when a video already had been previously converted. Currently running `docker compose exec photoprism photoprism convert` is a very quiet command with basically no output if already run at a previous point, leaving me unsure how much progress has been achieved. This small log fixes that by providing a quick log about where the converter is right now
@CLAassistant

CLAassistant commented Sep 24, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@lastzero

Copy link
Copy Markdown
Member

@Akashic101 My apologies for not getting back to you any sooner!

We should be able to merge this if you change the log message as follows:

convert: %s is AVC encoded, no transcoding required

@lastzero lastzero added enhancement video Video Formats, Transcoding, FFmpeg, Streaming & Co needs-work Has problems that need to be resolved labels Mar 27, 2025
@lastzero lastzero changed the title Add log-statement to convert_video_avc.go Videos: Add log-statement to convert_video_avc.go Mar 27, 2025
lastzero added a commit that referenced this pull request Mar 27, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero lastzero added resolved Implemented or no longer wanted/required and removed needs-work Has problems that need to be resolved labels Mar 27, 2025
@lastzero lastzero removed their assignment Mar 27, 2025
@lastzero lastzero moved this to Preview 🐳 in Roadmap πŸš€βœ¨ Mar 27, 2025
@lastzero

Copy link
Copy Markdown
Member

@Akashic101 I'm happy to report that your proposal has been implemented as part of the above commit. I will therefore close this PR as it is no longer needed. Thank you for your contribution! πŸ‘

@lastzero lastzero closed this Mar 27, 2025
@graciousgrey graciousgrey moved this from Preview 🐳 to Release 🌈 in Roadmap πŸš€βœ¨ Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

resolved Implemented or no longer wanted/required video Video Formats, Transcoding, FFmpeg, Streaming & Co

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants