Fix: timezone handling in sidebar component#5015
Merged
Conversation
Member
|
Thank you very much! I'll merge this for further testing 👍 |
lastzero
added
bug
graciousgrey
added
tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend stores the TakenAtLocal value as the local time of the specified timezone, like Berlin's time for Europe/Berlin. If we interpret TakenAtLocal with the timezone (DateTime.fromISO(time, {zone: timezone})), it results in a double time offset. To fix this, we should interpret TakenAtLocal as UTC to avoid time shifts, add timezone information only for display (using keepLocalTime: true), and thus preserve the correct local time while showing the timezone.
Related Issues: