Repository navigation
UX: Improve people name editing and confirm dialog focus management - #5307
Merged
Merged
Conversation
Adds better menu control and confirmation dialog handling for editing people names in photo edit and new people pages. Ensures only one menu is open at a time, improves keyboard accessibility, and prevents conflicting confirmation dialogs. Also updates event handling and emits for dialog and people components.
Signed-off-by: Michael Mayer <michael@photoprism.app>
Member
|
@omerdduran Thanks for pushing this forward! I added a focus trap to the confirmation dialog and adjusted the menu properties to use an invisible scrim layer in the background. Theresa said that with these changes, everything seems to be working, but more testing is needed after the changes are merged into the I don't think the class |
lastzero
added a commit
that referenced
this pull request
Nov 11, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero
added a commit
that referenced
this pull request
Nov 11, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero
added a commit
that referenced
this pull request
Nov 11, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero
added a commit
that referenced
this pull request
Nov 11, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero
added a commit
that referenced
this pull request
Nov 11, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero
added a commit
that referenced
this pull request
Nov 11, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero
added a commit
that referenced
this pull request
Nov 11, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero
added a commit
that referenced
this pull request
Nov 11, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes improve the reliability and user experience when editing the name of a person/face in the photo editing dialog and on the new People page:
Related Issues
VComboboxmenu rendering in dialogsΒ #5313