Skip to content

UX: Improve people name editing and confirm dialog focus management - #5307

Merged
lastzero merged 11 commits into
developfrom
fix-person-add
Nov 10, 2025
Merged

lastzero merged 11 commits into
developfrom
fix-person-add

Conversation

@omerdduran

@omerdduran omerdduran commented Nov 4, 2025 •

Copy link
Copy Markdown
Collaborator

These changes improve the reliability and user experience when editing the name of a person/face in the photo editing dialog and on the new People page:

  • A more robust confirmation process for renaming or assigning people is introduced, ensuring that only one menu is open at a time while also improving keyboard and menu interactions.
  • Additionally, the view helper now automatically traps focus in dialog overlays.

Related Issues

@lastzero

Copy link
Copy Markdown
Member

@omerdduran Thanks for pushing this forward!

I added a focus trap to the confirmation dialog and adjusted the menu properties to use an invisible scrim layer in the background. Theresa said that with these changes, everything seems to be working, but more testing is needed after the changes are merged into the develop branch.

I don't think the class .text-selectable is necessary for <v-combobox>, as text in inputs should be selectable by default. Could you do some additional testing? If you find that the class makes no difference, simply remove it.

@lastzero lastzero changed the title Frontend: Improve people name editing and confirmation UX UX: Improve people name editing and confirm dialog focus management Nov 10, 2025
@lastzero
lastzero merged commit 2cc1860 into develop Nov 10, 2025
1 check passed
@lastzero lastzero added please-test Ready for manual testing & feedback ux Impacts User Experience faces Face Detection, Recognition and Search labels Nov 10, 2025
@lastzero lastzero moved this to Preview 🐳 in Roadmap πŸš€βœ¨ Nov 10, 2025
lastzero added a commit that referenced this pull request Nov 11, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this pull request Nov 11, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this pull request Nov 11, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this pull request Nov 11, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this pull request Nov 11, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this pull request Nov 11, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this pull request Nov 11, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this pull request Nov 11, 2025
Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this pull request Nov 11, 2025


Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this pull request Nov 12, 2025


Signed-off-by: Michael Mayer <michael@photoprism.app>
lastzero added a commit that referenced this pull request Nov 12, 2025


Signed-off-by: Michael Mayer <michael@photoprism.app>
@graciousgrey graciousgrey added tested Changes have been tested successfully and removed please-test Ready for manual testing & feedback labels Nov 22, 2025
@lastzero lastzero moved this from Preview 🐳 to Release 🌈 in Roadmap πŸš€βœ¨ Dec 1, 2025
@lastzero
lastzero deleted the fix-person-add branch May 30, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

faces Face Detection, Recognition and Search tested Changes have been tested successfully ux Impacts User Experience

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants