Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torch.no_grad() for feature computation #175

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Add torch.no_grad() for feature computation #175

merged 1 commit into from
Oct 1, 2020

Conversation

zakajd
Copy link
Collaborator

@zakajd zakajd commented Oct 1, 2020

Closes #147

Proposed Changes

  • Add context wrapper for feature extractor function to avoid big memory consumption

@sonarcloud
Copy link

sonarcloud bot commented Oct 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #175 into master will increase coverage by 1.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   93.05%   94.81%   +1.76%     
==========================================
  Files          25       25              
  Lines        1698     1698              
==========================================
+ Hits         1580     1610      +30     
+ Misses        118       88      -30     
Flag Coverage Δ
#unittests 94.81% <ø> (+1.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
piq/perceptual.py 100.00% <ø> (ø)
piq/gs.py 73.41% <0.00%> (+37.97%) ⬆️

@snk4tr snk4tr merged commit 855ea44 into master Oct 1, 2020
@snk4tr snk4tr deleted the bug/no_grad branch October 1, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add toch.no_grad() for feature computation
3 participants