Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in FSIMc #200

Merged
merged 5 commits into from
Jan 15, 2021
Merged

Fix bug in FSIMc #200

merged 5 commits into from
Jan 15, 2021

Conversation

zakajd
Copy link
Collaborator

@zakajd zakajd commented Dec 21, 2020

Closes #199

Proposed Changes

  • Add check for number of channels
  • Improve tests

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #200 (b196969) into master (b4c4919) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   95.34%   95.35%           
=======================================
  Files          26       26           
  Lines        1784     1785    +1     
=======================================
+ Hits         1701     1702    +1     
  Misses         83       83           
Flag Coverage Δ
unittests 95.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
piq/fsim.py 100.00% <100.00%> (ø)

@snk4tr
Copy link
Contributor

snk4tr commented Jan 13, 2021

@denproc we can close this one without you if you have not time now. What do you think?

Copy link
Collaborator

@denproc denproc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@sonarcloud
Copy link

sonarcloud bot commented Jan 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@denproc denproc merged commit 0274265 into master Jan 15, 2021
@snk4tr snk4tr deleted the bug/fsim_c branch January 16, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter "chromatic" set to True causes failure of SSIM if greyscale image
3 participants