New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coding standard] fix imports order and remove unused docs #145

Merged
merged 2 commits into from Nov 6, 2017

Conversation

Projects
None yet
2 participants
@TomasVotruba
Copy link
Contributor

TomasVotruba commented Nov 6, 2017

Found some time to clean up :)

PHPStan could come handy, I found many misstypes of parent classes/interfaces, e.g. float/int/array mixtures.

@TomasVotruba

This comment has been minimized.

Copy link
Contributor

TomasVotruba commented Nov 6, 2017

Codeclimate reports false positive - includes return type to argument count

Ready to merge

@akondas

This comment has been minimized.

Copy link
Contributor

akondas commented Nov 6, 2017

Thanks 👍

@akondas akondas merged commit f4650c6 into php-ai:master Nov 6, 2017

1 of 2 checks passed

codeclimate 2 issues to fix
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@TomasVotruba TomasVotruba deleted the TomasVotruba:coding-standard branch Nov 6, 2017

@TomasVotruba TomasVotruba changed the title [coding standard] fix imports order [coding standard] fix imports order and remove unused docs Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment