New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PHP 7.1 #150

Merged
merged 3 commits into from Nov 14, 2017

Conversation

Projects
None yet
2 participants
@TomasVotruba
Contributor

TomasVotruba commented Nov 14, 2017

Let's take it one step at a time.

This is ready to merge

@akondas

This comment has been minimized.

Show comment
Hide comment
@akondas

akondas Nov 14, 2017

Contributor

Man, are you ever sleeping? I will make code review and merge if everything is ok :D

Contributor

akondas commented Nov 14, 2017

Man, are you ever sleeping? I will make code review and merge if everything is ok :D

@TomasVotruba

This comment has been minimized.

Show comment
Hide comment
@TomasVotruba

TomasVotruba Nov 14, 2017

Contributor

You think I've done this manually? ;)

Not much lately, to much passion around Rector and automated upgrades :)

Contributor

TomasVotruba commented Nov 14, 2017

You think I've done this manually? ;)

Not much lately, to much passion around Rector and automated upgrades :)

@akondas

This comment has been minimized.

Show comment
Hide comment
@akondas

akondas Nov 14, 2017

Contributor

Rector is great. I'm going to show Rector in polish php community Phpers (polsih version of Pehapkari).
You have plans to change some other thing or I can do release?

Contributor

akondas commented Nov 14, 2017

Rector is great. I'm going to show Rector in polish php community Phpers (polsih version of Pehapkari).
You have plans to change some other thing or I can do release?

@TomasVotruba

This comment has been minimized.

Show comment
Hide comment
@TomasVotruba

TomasVotruba Nov 14, 2017

Contributor

Do you mean strilecky? ;)

Cool! 🥇 It still in development, so report any issue you find.

You have plans to change some other thing or I can do release?

This is all for PHP 7.1 and it's lot of changes.

When this get merged, I'll prepare PR coding standard setup 🌷

Contributor

TomasVotruba commented Nov 14, 2017

Do you mean strilecky? ;)

Cool! 🥇 It still in development, so report any issue you find.

You have plans to change some other thing or I can do release?

This is all for PHP 7.1 and it's lot of changes.

When this get merged, I'll prepare PR coding standard setup 🌷

@@ -17,7 +17,7 @@
}
},
"require": {
"php": ">=7.0.0"
"php": "^7.1"

This comment has been minimized.

@akondas

akondas Nov 14, 2017

Contributor

🎉

@akondas

akondas Nov 14, 2017

Contributor

🎉

@akondas

This comment has been minimized.

Show comment
Hide comment
@akondas

akondas Nov 14, 2017

Contributor

Very good 👍

Contributor

akondas commented Nov 14, 2017

Very good 👍

@akondas akondas merged commit 653c7c7 into php-ai:master Nov 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@akondas akondas referenced this pull request Nov 14, 2017

Closed

Bump to PHP 7.1 #148

@TomasVotruba TomasVotruba deleted the TomasVotruba:rector-nai branch Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment