fixed composer autoloading usage #41

Merged
merged 5 commits into from Oct 12, 2012

Conversation

Projects
None yet
2 participants
Contributor

brikou commented Oct 12, 2012

Hi,

I've removed submodules related to sf class loader and updated code to only use composer's autoloading system

cheer...

Collaborator

videlalvaro commented Oct 12, 2012

Can you see why the tests failed? I assume the autoload code for the tests is not working properly

Contributor

brikou commented Oct 12, 2012

With or without my changes, phpunit leads to the same results... (3 errors)

on master banch

PHPUnit 3.7.1 by Sebastian Bergmann.

Configuration read from /mnt/hgfs/www/php-amqplib/phpunit.xml

............................EEE

Time: 8 seconds, Memory: 4.50Mb

There were 3 errors:

1) PhpAmqpLib\Tests\Functional\Bug40Test::testFrameOrder
Exception: Error reading data. Received 0 instead of expected 1 bytes

/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Wire/AMQPReader.php:62
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Wire/AMQPReader.php:94
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Connection/AMQPConnection.php:267
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Connection/AMQPConnection.php:287
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Channel/AbstractChannel.php:142
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Channel/AbstractChannel.php:239
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Connection/AMQPConnection.php:100
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Tests/Functional/Bug40Test.php:17

2) PhpAmqpLib\Tests\Functional\FileTransferTest::testSendFile
Exception: Error reading data. Received 0 instead of expected 1 bytes

/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Wire/AMQPReader.php:62
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Wire/AMQPReader.php:94
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Connection/AMQPConnection.php:267
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Connection/AMQPConnection.php:287
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Channel/AbstractChannel.php:142
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Channel/AbstractChannel.php:239
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Connection/AMQPConnection.php:100
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Tests/Functional/FileTransferTest.php:15

3) PhpAmqpLib\Tests\Functional\PublishConsumeTest::testPublishConsume
Exception: Error reading data. Received 0 instead of expected 1 bytes

/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Wire/AMQPReader.php:62
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Wire/AMQPReader.php:94
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Connection/AMQPConnection.php:267
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Connection/AMQPConnection.php:287
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Channel/AbstractChannel.php:142
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Channel/AbstractChannel.php:239
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Connection/AMQPConnection.php:100
/mnt/hgfs/www/php-amqplib/PhpAmqpLib/Tests/Functional/PublishConsumeTest.php:15

FAILURES!
Tests: 31, Assertions: 347, Errors: 3.

on my PR branch

# just the same as above
Contributor

brikou commented Oct 12, 2012

I guess I should update bin/ci/before_build.sh in order to install composer...

Contributor

brikou commented Oct 12, 2012

@videlalvaro great travis is now fine with my PR ;)

Collaborator

videlalvaro commented Oct 12, 2012

To run the tests we need to setup some users in the server. I think I will try to fix that in the future

Collaborator

videlalvaro commented Oct 12, 2012

I think the missing change then is to cleaup the makefile

Contributor

brikou commented Oct 12, 2012

@videlalvaro Makefile is now cleaned up, but I just don't know the purpose of this file :)

Collaborator

videlalvaro commented Oct 12, 2012

So what are the steps now to get the autoloader?

My question here is. I clone this library and then it's ready to use or do I need to run some command, like install composer, then run some composer command to fetch libs or whatever?

If so please add that to the readme

Makefile
-$(CLASS_LOADER):
- git submodule init
- git submodule update
-
test: all
@videlalvaro

videlalvaro Oct 12, 2012

Collaborator

all should be removed because you deleted the all target

Makefile
test: all
phpunit
-
benchmark: all
@videlalvaro

videlalvaro Oct 12, 2012

Collaborator

all should be removed because you deleted the all target

Contributor

brikou commented Oct 12, 2012

I've fixed the Makefile...

Collaborator

videlalvaro commented Oct 12, 2012

What about my question before? I sincerely don't have much experience with composer so I don't know that

Contributor

brikou commented Oct 12, 2012

I guess now everything is fine ;)

Collaborator

videlalvaro commented Oct 12, 2012

Listo! Thanks

videlalvaro added a commit that referenced this pull request Oct 12, 2012

Merge pull request #41 from brikou/dev_composer
fixed composer autoloading usage

@videlalvaro videlalvaro merged commit a0c3be4 into php-amqplib:master Oct 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment