Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fixed coding standard to be psr compliant #42

Merged
merged 2 commits into from Oct 12, 2012

Conversation

Projects
None yet
2 participants
Contributor

brikou commented Oct 12, 2012

fixed cs using php cs fixer

@videlalvaro videlalvaro commented on an outdated diff Oct 12, 2012

PhpAmqpLib/Channel/AMQPChannel.php
* @throws \InvalidArgumentException if $callback is not callable
*/
- public function set_return_listener($callback){
- if(!is_callable($callback))
- throw new \InvalidArgumentException('$callback should be callable.');
- $this->basic_return_callback = $callback;
+ public function set_return_listener($callback)
+ {
+ if(!is_callable($callback))
+ throw new \InvalidArgumentException('$callback should be callable.');
@videlalvaro

videlalvaro Oct 12, 2012

Collaborator

Now that I see we need double quotes here right? Else $callback won't be in the output

Collaborator

videlalvaro commented Oct 12, 2012

Would you mind fixing that small issue I've found that was there even before your changes? After that I press the button :)

Contributor

brikou commented Oct 12, 2012

@videlalvaro done ;)

videlalvaro added a commit that referenced this pull request Oct 12, 2012

Merge pull request #42 from brikou/dev_psr
fixed coding standard to be psr compliant

@videlalvaro videlalvaro merged commit 8a393d2 into php-amqplib:master Oct 12, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment