Catch a couple exceptions in select

[lukebakken]

Fixes #627

@programmer512 please review and test if you have time, thanks.

@ramunasd - if you have a second to read #627 and review, I would appreciate it.

[ramunasd]

Hi @lukebakken , thanks for fix. I thought this is fixed after #653. But looks like AbstractConnection->select() is yet another place where things can go wrong.
I suggest to extend AMQPHeartbeatMissedException from AMQPConnectionClosedException ( missed heartbeat is subset of all closed connection issues) and catch AMQPConnectionClosedException here:

php-amqplib/PhpAmqpLib/Connection/AbstractConnection.php

Line 314 in 3e1a2eb

} catch (AMQPHeartbeatMissedException $e) {

Then we will keep consistent exception handling in all places. Agree?

[lukebakken]

@ramunasd thank you for the suggestion. This is the last item for 2.9.0 🎉 ... if you have a second for a final review, that would be great. Thanks!

[ramunasd]

LGTM, tested it additionaly using testsuites from php-enqueue.

[lukebakken]

Thanks!

[programmer512]

@lukebakken thank you for fix.
But my problem was inside check_heartbeat() function which is called from StreamIO::read() method, not from AbstractConnection::select(), and this exception "AMQPHeartbeatMissedException" is thrown from there

public function read($len)
{
$this->check_heartbeat();

[lukebakken]

This should be caught in AbstractConnection now that AMQPHeartbeatMissedException derives from AMQPConnectionClosedException. There are only three places where read is called on an AMQPReader instance and AMQPConnectionClosedException is handled.

@ramunasd @programmer512 if this could be verified that would be great.

[programmer512]

@lukebakken, thank you.
I will prepare a test and verify it.

[programmer512]

@ramunasd , @lukebakken thank you very much
You are completely right. I did not notice that inside AbstractConnection::wait_frame there is a catch for AMQPConnectionClosedException. So no problem then. Everything is clear and correct from my side.
Sorry for disturbing you because of misunderstanding

[lukebakken]

I appreciate that you verified this @programmer512 !!!!